thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.28.3 2017-10-10T01:24:02Z 2017-10-10T01:24:02Z Jani Nikula jani@nikula.org 2017-10-07T08:44:04Z urn:sha1:0f314c0c99befea599a68bea51d759b4133efef6 C99 stdbool turned 18 this year. There really is no reason to use our own, except in the library interface for backward compatibility. Convert the cli and test binaries to stdbool. 2017-10-05T01:00:42Z Jani Nikula jani@nikula.org 2017-10-01T20:53:11Z urn:sha1:4a6721970a42a9f86149fb5d395d1001fed2d305 Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output variables, where the output variable being non-NULL determines the type. Introduce checks to ensure only one is set. The downside is some waste of const space per argument; this could be saved by retaining opt_type and using a union, but that's still pretty verbose. - Fix some variables due to the type safety. Mostly a good thing, but leads to some enums being changed to ints. This is pedantically correct, but somewhat annoying. We could also cast, but that defeats the purpose a bit. - Terminate the opt desc arrays using {}. The output variable type safety and the ability to add new fields for just some output types or arguments are the big wins. For example, if we wanted to add a variable to set when the argument is present, we could do so for just the arguments that need it. Beauty is in the eye of the beholder, but I think this looks nice when defining the arguments, and reduces some of the verbosity we have there. 2017-08-30T10:10:07Z David Bremner david@tethera.net 2017-08-26T14:41:38Z urn:sha1:c960bb4686429b220419f6d45ede920d6c14c3c5 Fix the following cppcheck errors: notmuch-count.c:207: error: Resource leak: input notmuch-tag.c:238: error: Resource leak: input We know that the program is shutting down here, but it does no harm to clean up a bit. 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:32Z urn:sha1:86cbd215eb67d7b996c977352a50e70c101cb641 This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2015-11-19T11:50:58Z Daniel Schoepe daniel@schoepe.org 2015-08-11T07:46:37Z urn:sha1:8b5644e63d49a8841d32130d67c465da0623db74 This patch removes the restriction on notmuch-tag that disallows using both --remove-all and --batch. Combining the two options removes tags on all messages affected by each query before applying the new tags. 2015-09-23T11:03:34Z David Bremner david@tethera.net 2015-09-06T13:15:47Z urn:sha1:6cdd34a4c762c954426f586d514a3e041c1db3b0 I think it would be no real problem to cut and paste the gdb based error message test from count to the other clients modified here, but I'm not currently convinced it's worth the trouble since the code path being tested is almost the the same, and the tests are relatively heavyweight. 2015-08-14T16:23:49Z David Bremner david@tethera.net 2015-04-05T22:39:55Z urn:sha1:f76d8f82dd004cf14426a91e8a80dcd2a4b97317 The function notmuch_exit_if_unmatched_db_uuid is split from notmuch_process_shared_options because it needs an open notmuch database. There are two exceptional cases in uuid handling. 1) notmuch config and notmuch setup don't currently open the database, so it doesn't make sense to check the UUID. 2) notmuch compact opens the database inside the library, so we either need to open the database just to check uuid, or change the API. 2015-06-01T05:32:54Z David Bremner david@tethera.net 2015-04-05T13:13:03Z urn:sha1:0018a8d787a98f80c665061daa9b0c73839d3666 Unfortunately it seems trickier to support --config globally The non-trivial changes are in notmuch.c; most of the other changes consists of blindly inserting two lines into every subcommand. 2015-05-31T17:14:42Z J. Lewis Muir jlmuir@imca-cat.org 2015-05-27T17:53:52Z urn:sha1:d08af93c65310c2d5ec8033040854f8ff4e5550f The word "setup" is a noun, not a verb. Change occurrences of "setup" where used as a verb to "set up".