notmuch/notmuch-tag.c, branch 0.6

Remove some variables which were set but not used.

2011-05-11T20:27:14Z

gcc (at least as of version 4.6.0) is kind enough to point these out to us, (when given -Wunused-but-set-variable explicitly or implicitly via -Wunused or -Wall). One of these cases was a legitimately unused variable. Two were simply variables (named ignored) we were assigning only to squelch a warning about unused function return values. I don't seem to be getting those warnings even without setting the ignored variable. And the gcc docs. say that the correct way to squelch that warning is with a cast to (void) anyway.

lib: Rework interface for maildir_flags synchronization

2010-11-11T11:40:19Z

Instead of having an API for setting a library-wide flag for synchronization (notmuch_database_set_maildir_sync) we instead implement maildir synchronization with two new library functions: notmuch_message_maildir_flags_to_tags and notmuch_message_tags_to_maildir_flags These functions are nicely documented here, (though the implementation does not quite match the documentation yet---as plainly evidenced by the current results of the test suite).

Avoid abbreviation, preferring notmuch_config_get_maildir_synchronize_flags

2010-11-11T11:40:19Z

Since the name of the configuration parameter here is: maildir.synchronize_flags the convention is that the functions to get and set this parameter should match it in name. Hence: notmuch_config_get_maildir_synchronize_flags etc. (as opposed to notmuch_config_get_maildir_sync).

Make maildir synchronization configurable

2010-11-10T21:09:32Z

This adds group [maildir] and key 'synchronize_flags' to the configuration file. Its value enables (true) or diables (false) the synchronization between notmuch tags and maildir flags. By default, the synchronization is disabled.

notmuch-tag: don't sort messages before applying tag changes

2010-04-21T23:06:09Z

It's not neccessary to sort the results before we apply tags. Xapian contributor Olly Betts says that savings might be bigger with a cold file cache and (as unsorted implies really sorted by document id) a better cache locality when applying tags to messages. Signed-off-by: Sebastian Spaeth

lib: Rename iterator functions to prepare for reverse iteration.

2010-03-09T17:22:29Z

We rename 'has_more' to 'valid' so that it can function whether iterating in a forward or reverse direction. We also rename 'advance' to 'move_to_next' to setup parallel naming with the proposed functions 'move_to_first', 'move_to_last', and 'move_to_previous'.

Avoid compiler warnings due to ignored write return values

2009-12-01T15:50:35Z

Glibc (at least) provides the warn_unused_result attribute on write, (if optimizing and _FORTIFY_SOURCE is defined). So we explicitly ignore the return value in our signal handler, where we couldn't do anything anyway. Compile with: make CFLAGS="-O -D_FORTIFY_SOURCE" before this commit to see the warning.

lib/query: Drop the first and max_messages arguments from search_messages.

2009-11-24T04:25:13Z

These only existed to support the chunky-searching hack, but that was recently dropped anyway.

Rename NOTMUCH_DATABASE_MODE_WRITABLE to NOTMUCH_DATABASE_MODE_READ_WRITE

2009-11-21T21:10:18Z

And correspondingly, READONLY to READ_ONLY.

Permit opening the notmuch database in read-only mode.

2009-11-21T21:04:49Z

We only rarely need to actually open the database for writing, but we always create a Xapian::WritableDatabase. This has the effect of preventing searches and like whilst updating the index. Signed-off-by: Chris Wilson Acked-by: Carl Worth