notmuch/notmuch.c, branch 0.32thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.322021-04-07T00:32:36ZCLI: drop notmuch_config_t from subcommand interface.2021-04-07T00:32:36ZDavid Bremnerdavid@tethera.net2021-02-27T14:07:45Zurn:sha1:1c747a501c0ed7df5eaa2b994b9ad11d8981c62c
At this point it is unused in all subcommands.
CLI/config: remove calls to notmuch_config_open from top level2021-04-07T00:32:36ZDavid Bremnerdavid@tethera.net2021-02-27T13:22:32Zurn:sha1:ec4b7efbe4bd6d50bd6046bac5f7ef4ceaa30154
This will allow simplifying the subcommand interface.
Change the internal API to notmuch_config_open to not tie it to the
implementation of subcommands in notmuch.c.
It also fixes a previously broken test, since notmuch_config_open does
not understand the notion of the empty string as a config file name.
CLI/config: support set/get with split configuration2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-25T12:00:26Zurn:sha1:77d4b26d3e374afac0012148a8ac0a08158406f1
There are two small code changes. The main one is to retrieve the
possibly updated config file name found during the database opening
call. The second change is to allow empty config file names, as
a (currently broken) way of specifying that configuration should only
be taken from the database.
CLI+lib: detect missing database in split configurations.2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-23T20:19:13Zurn:sha1:217f8196088f200972d35ee9181bfe361cccc04a
Eventually we want to do all opening of databases in the top
level (main function). This means that detection of missing databases
needs to move out of subcommands. It also requires updating the
library to use the new NO_DATABASE status code.
CLI/notmuch: switch notmuch_command to notmuch_config_get2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-23T13:22:37Zurn:sha1:8d5b8753cf9292d7b316bee7d3de2239d6b41e6d
The goal at this point is to remove the dependence on
notmuch_config_get_* without breaking any existing functionality. This
is a step towards removing notmuch_config_get_* in a future commit.
CLI/config: migrate notmuch_config_open to new config2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-14T13:32:41Zurn:sha1:b76da87d29b6c9714e3d62fd8d459733df084f92
notmuch_config_open will be preserved in the medium term for use by
the commands that are manipulating the config file directly (config
and setup)
CLI/setup: switch to new configuration framework2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-13T17:49:32Zurn:sha1:34f734e26b1202cbfbbd06293962571538188fc4
Most of the changes are the elimination of notmuch_config_t accessor
use. We also migrate some of the diagnostics to the top level where we
are opening the files in question.
CLI: load merged config at top level2021-03-27T12:26:14ZDavid Bremnerdavid@tethera.net2021-02-10T00:26:40Zurn:sha1:d9bc5c85288526e1e063e14fa00517e8f953be16
This paves the way for the conversion of the remaining subcommands to
the new configuration framework.
CLI/show: complete conversion to new configuration framework.2021-03-20T01:06:19ZDavid Bremnerdavid@tethera.net2021-02-06T22:50:20Zurn:sha1:6e6c319c260b779e6e91905f8c142ad2b82a41c9
In order to open the database in main() for this command, we may need
to re-open it in the (possibly less common) case where crypto options
require write access.
cli: run uncrustify2021-03-13T12:45:34Zuncrustifydavid@tethera.net2021-03-13T12:45:34Zurn:sha1:eef21c284742fa5ae14d7d352acc3a4dc98821ce
This is the result of running
$ uncrustify --replace --config devel/uncrustify.cfg *.c *.h
in the top level source directory
Line breaks were then adjusted manually to keep argc and argv
together.