notmuch/notmuch.c, branch 0.39_rc2thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.39_rc22023-09-23T11:34:48ZPass error message from GLib ini parser to CLI2023-09-23T11:34:48ZDavid Bremnerdavid@tethera.net2023-09-15T12:50:04Zurn:sha1:1c10d91d8e4a3e5bc76ca4c6b9939f3759e6ef5e
The function _notmuch_config_load_from_file is only called in two
places in open.cc. Update internal API to match the idiom in open.cc.
Adding a newline is needed for consistency with other status strings.
Based in part on a patch [1] from Eric Blake.
[1]: id:20230906153402.101471-1-eblake@redhat.com
CLI: exit with error when load_config returns an error.2023-09-23T11:26:40ZDavid Bremnerdavid@tethera.net2023-09-15T12:50:02Zurn:sha1:dbb5ff338511bfa6718ed144b95a689809d4bea1
For now print a generic error message and exit with error on any
non-success code. Previously the code exited, but with exit code zero,
leading users / scripts to think the command had succeeded.
notmuch.c: add missing trailing newlines in two error messages2022-08-01T00:03:59ZTomi Ollilatomi.ollila@iki.fi2022-07-31T17:32:11Zurn:sha1:54190d091cbceb345c489bd3f20fdca7e4b9a111
Removed duplicate error check (and the message) in 3rd case where
the same error message (w/o trailing newline) was present.
In case of test/T040-setup.sh, command substitution deletes
trailing newlines, so related test there cannot be changed
(and therefore could not notice this user experience flaw).
CLI: pass --config to external commands via NOTMUCH_CONFIG.2022-06-13T10:28:05ZDavid Bremnerdavid@tethera.net2022-05-31T11:50:59Zurn:sha1:5cbddf7e7a96a801e5ad3482b2636aff375a0821
This makes `notmuch --config foo external-subcommand` work
consistently with the built in subcommands.
CLI: mention sexp-queries in help topics, alphabetize2022-06-13T10:18:26ZDavid Bremnerdavid@tethera.net2022-05-29T18:22:04Zurn:sha1:82957c963296bb9d2147ce5374b940463facd9ec
There does not seem to be an easy way to automate maintaining this
list, but new topics are not added very often.
CLI: simplify help command2022-06-13T10:17:59ZDavid Bremnerdavid@tethera.net2022-05-29T18:22:03Zurn:sha1:52470ddfbfaeac8e5530e32d45bd6259d4326517
This will allow "notmuch help" to work for arbitrary external commands
and for any added non-command topics (such as notmuch-sexp-queries).
CLI: move indexopts variable out of shared options block2021-10-23T12:51:50ZDavid Bremnerdavid@tethera.net2021-06-12T13:26:17Zurn:sha1:2ce6c76a61c907b5d1d508e12255e83d9256937c
This reduces the amount of global state. Furthermore, index options
can be set (in principle) in several ways, not just in the one
function for processing indexing command line options.
CLI: move query syntax to shared option2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:42Zurn:sha1:a2e7af5b6986bca5a2bb2752f892cb86a9767b3c
This will allow easy addition of a query syntax option to other subcommands.
CLI: make variable n_requested_db_uuid file scope.2021-09-05T00:07:19ZDavid Bremnerdavid@tethera.net2021-08-24T15:17:10Zurn:sha1:d447b694b498c3e18a22f1eb15139a798c6aab26
It turns out that now that we pass an open database into the
subcommands, it is easy to check any requested uuid against the
database at the same time as we process the other shared
arguments. This results in overall less boilerplate code, as well as
making a CLI scope function and variable file scope in notmuch.c.
lib: write talloc report in notmuch_database_destroy2021-06-25T12:20:37ZDavid Bremnerdavid@tethera.net2021-06-19T00:59:43Zurn:sha1:ea301102abc55404b8b447cd50998429bfbbf9fd
Since most memory allocation is (ultimately) in the talloc context
defined by a notmuch_database_t pointer, this gives a more complete
view of memory still allocated at program shutdown.
We also change the talloc report in notmuch.c to mode "a" to avoid
clobbering the newly reported log.