notmuch/show-message.c, branch 0.10.2

Improve handling of message/rfc822 parts by adding a new header_message_part function to the formating structure.

2011-09-06T01:58:52Z

This new function takes a GMimeMessage as input, and outputs the formatted headers. This allows for message/rfc822 parts to be formatted on output in a similar way to full messages (see previous patch that overhauls the multipart test for more info).

Render all parts of multipart/encrypted when decrypting.

2011-05-27T23:22:00Z

The primary goal here is to keep the decrypted output as similarly structured as undecrypted output as possible. Now, when decrypting parts, only the original encrypted part is replaced by the it's decrypted content. If this part isn't itself a multipart, then all part numbering should remain consistent during decryption. The only draw back here is that the useless application/pgp-encrypted sub-part of the multipart/encrypted part is also emitted. But this part can be easily ignored by clients.

Do not replace multipart/signed part with content part when doing verification.

2011-05-27T23:22:00Z

Some folks have complained about the part renumbering that occurs when the entire multipart/signed part is replaced with the part contents after verification. This is primarily because it incurs an additional computational cost to retrieve individual parts, since verification has to be performed again to ensure that part numbering is consistent. This patch simply leaves the full multipart/signed part as is. The emacs crypto test is also updated to reflect this change.

Add decryption of PGP/MIME-encrypted parts with --decrypt.

2011-05-27T23:22:00Z

This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire multipart/encrypted part is replaced by the contents of the encrypted part. At the moment only a json part_encstatus formatting function is available, even though decryption is done for all formats. Emacs support to follow.

Add signature verification of PGP/MIME-signed parts with --verify.

2011-05-27T23:22:00Z

This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus formatting function is available. Emacs support to follow. The original work for this patch was done by Daniel Kahn Gillmor whose help with this functionality I greatly appreciate.

Break up format->part function into part_start and part_content functions.

2011-05-27T23:18:57Z

Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions.

Use empty strings instead of NULL in format_reply structure.

2011-05-27T23:18:57Z

This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats.

notmuch reply: Avoid segmentation fault when printing multiple parts

2011-05-24T19:19:18Z

The code was previously trying to print a NULL string in this case, which is obviously what we don't want to do.

New part output handling as option to notmuch-show.

2011-05-23T22:31:32Z

Outputting of single MIME parts is moved to an option of notmuch show, instead of being handled in it's own sub-command. The recent rework of multipart mime allowed for this change but consolidating part handling into a single recursive function (show_message_part) that includes formatting. This allows for far simpler handling single output of a single part, including formatting.

Normalize part counting and formatting in show_message_part function.

2011-05-23T22:30:26Z

Simplify the function by moving part counting and formatting outside of conditionals, thereby eliminating redundant code. This also wraps message part output handling with proper part formatting.