notmuch/tag-util.c, branch 0.24.2 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.24.2 2014-03-06T11:46:27Z cli: add missing \n in error message 2014-03-06T11:46:27Z Jani Nikula jani@nikula.org 2014-03-04T16:51:54Z urn:sha1:735cbb8719068c4741ed0a4f5ea68f2ed31b7009 The error messages returned by illegal_tag() don't contain newlines. cli: export function for illegal tag checking 2014-03-06T11:41:38Z Jani Nikula jani@nikula.org 2014-02-23T16:55:21Z urn:sha1:07dd9d53cb7d92dc42ef697edb65e4c491b65928 This lets us check for forbidden tags consistently across the cli. No functional changes. tag-util: do not reset list in parse_tag_command_line 2013-06-29T17:36:23Z Peter Wang novalazy@gmail.com 2013-06-23T04:23:55Z urn:sha1:f00c925bd10c024d5b9f88d8903c7a0d14e9cc6a The 'insert' command will be better served if parse_tag_command_line modifies a pre-populated list (of new.tags) instead of clobbering the list outright. The sole existing caller, notmuch_tag_command, is unaffected by this change. tag-util: move out 'tag' command-line check 2013-06-29T17:36:07Z Peter Wang novalazy@gmail.com 2013-06-23T04:23:54Z urn:sha1:e8efa11da90fa47adcbc489638320d61ac98391a Move an error condition specific to the 'tag' command out of parse_tag_command_line so that parse_tag_command_line can be used for the forthcoming 'insert' command. cli: make caller check tag count in parse_tag_command_line 2013-03-30T22:33:40Z Jani Nikula jani@nikula.org 2013-03-09T14:56:48Z urn:sha1:a6822eccaca773aa03473bca490618e30dac24ca notmuch-tag.c: convert to use tag-util 2013-01-08T00:42:21Z David Bremner bremner@debian.org 2012-12-25T19:42:39Z urn:sha1:e9b6e464745fdebd4c6367dfc731859fe390b531 Command line parsing is factored out into a function parse_tag_command_line in tag-util.c. There is some duplicated code eliminated in tag_query, and a bunch of translation from using the bare tag_op structs to using that tag-utils API. tag-util: factor out rules for illegal tags, use in parse_tag_line 2013-01-07T02:57:41Z David Bremner bremner@debian.org 2012-12-25T19:42:38Z urn:sha1:e13e2591470f849c86d410f50ec8103d2a5daf5b This will allow us to be consistent between batch tagging and command line tagging as far as what is an illegal tag. dump/restore: Use Xapian queries for batch-tag format 2013-01-07T02:40:32Z Austin Clements amdragon@MIT.EDU 2013-01-06T20:22:41Z urn:sha1:425e2bc81263230df301c67d93c64ff9685ff840 This switches the new batch-tag format away from using a home-grown hex-encoding scheme for message IDs in the dump to simply using Xapian queries with Xapian quoting syntax. This has a variety of advantages beyond presenting a cleaner and more consistent interface. Foremost is that it will dramatically simplify the quoting for batch tagging, which shares the same input format. While the hex-encoding is no better or worse for the simple ID queries used by dump/restore, it becomes onerous for general-purpose queries used in batch tagging. It also better handles strange cases like "id:foo and bar", since this is no longer syntactically valid. parse_tag_line: use enum for return value. 2012-12-26T13:44:31Z David Bremner bremner@debian.org 2012-12-25T19:42:37Z urn:sha1:1325e1afb9d93a26644803ec396ed2d87bf8b340 This is essentially cosmetic, since success=0 is promised by the comments in tag-utils.h. tag-utils: use the tag_opt_list_t as talloc context, if possible. 2012-12-23T03:13:15Z David Bremner bremner@debian.org 2012-12-16T19:58:15Z urn:sha1:ba4e8565294fc0a197b4c08082ad912c31888008 The memory usage discipline of tag_op_list_t is never to free the internal array of tag operations before freeing the whole list, so it makes sense to take advantage of hierarchical de-allocation by talloc. By not relying on the context passed into tag_parse_line, we can allow tag_op_list_t structures to live longer than that context.