notmuch/test/T050-new.sh, branch 0.21

cli: delete directory documents on directory removal

2015-10-14T10:55:41Z

There was a problem with the directory documents being left behind when the filesystem directory was removed. This was worked around in [1]. However, that ignored the fact that the directory documents are also still listed by notmuch_directory_get_child_directories() leading to confusing results when running notmuch new. The directory documents are found and queued for removal over and over again. Fix the problem for real by removing the directory documents. This fixes the tests flagged as broken in [2]. The (non-deterministic) hack test from [3] also still passes with this change. [1] commit acd66cdec075312944e527febd46382e54d99367 [2] commit ed9ceda623d3f22fb66365b33db63c5c982067d3 [3] id:1441445731-4362-1-git-send-email-jani@nikula.org

test: flag one more notmuch new test as broken

2015-10-10T12:13:02Z

Drop the test update added in [1] and mark the test as broken, like the tests flagged as broken in [2]. These all reflect the same underlying breakage with (lack of) directory deletion. [1] commit e4e04bbc328f990e36b77f508aef904d156029b1 [2] commit ed9ceda623d3f22fb66365b33db63c5c982067d3

test: make script exit (1) if it "fails" to source (.) a file

2015-08-07T19:56:39Z

The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero.

test: add debugging output to notmuch-new tests, mark 5 as broken

2015-08-04T19:00:09Z

I marked the tests where I really couldn't understand the output as broken. It could also be that I don't understand how directory removal is supposed to work.

cli/new: add more debugging output

2015-08-04T18:59:58Z

Try to narrow down what part of the code adds files and directories to the queue(s) to be deleted. Update one test. The output is slightly confusing, but I believe it is correct, resulting from a directory being discovered but containing only ignored files.

test: don't claim single message mbox support is going away

2015-08-04T18:59:50Z

We gave up on this.

test: Add two tests for error output from notmuch_database_open

2015-03-15T19:27:20Z

This is arguably testing the same thing twice, but in the brave new future where we don't use printf anymore, each subcommand will be responsible for handling the output on it's own.

lib: drop the deprecation message for single-message mbox files

2015-01-01T15:47:47Z

We generally do not support mbox files, but for historical reasons we've supported single-message mbox files, with a deprecation message. We've tried dropping the support altogether, but backed out of it because we'd need to stop indexing them, while keeping support for previously indexed files. This would be more complicated than simply supporting single-message mbox files. Therefore, drop the deprecation message, and just silently accept single-message mboxes.

lib: resurrect support for single-message mbox files

2014-06-14T01:59:04Z

This is effectively a revert of commit 6812136bf576d894591606d9e10096719054d1f9 Author: Jani Nikula Date: Mon Mar 31 00:21:48 2014 +0300 lib: drop support for single-message mbox files The intention was to drop support for indexing new single-message mbox files (and whether that was a good idea in the first place is arguable). However this inadvertently broke support for reading headers from previously indexed single-message mbox files, which is far worse. Distinguishing between the two cases would require more code than simply bringing back support for single-message mbox files.

lib: drop support for single-message mbox files

2014-04-05T15:52:42Z

We've supported mbox files containing a single message for historical reasons, but the support has been deprecated, with a warning message while indexing, since Notmuch 0.15. Finally drop the support, and consider all mbox files non-email.