notmuch/test/T050-new.sh, branch 0.26

test: test regexp based new.ignore

2017-12-15T11:55:02Z

Just some basics.

test: use $(dirname "$0") for sourcing test-lib.sh

2017-10-20T22:52:49Z

Don't assume the tests are always run from within the source tree.

test: Fix T050-new.sh on some Travis CI machines

2017-08-30T10:24:44Z

On some system configurations, setting a breakpoint on the "add_file" function then issuing "continue" in gdb causes the debugger to seemingly jump over the add_file invocation. This results in a test failure, as the "Handle files vanishing between scandir and add_file" subtest expects add_file to be called and fail due to the vanishing file. The compiler optimization level also plays a role - the problem can be reproduced with CFLAGS having -O2 but not -Og. This problem was observed manifesting as a test failure on Travis CI configured with "dist: trusty" and "sudo: false". It was not reproducible on a local Docker image of Travis' runtime environment, so Travis' virtualization infrastructure likely plays a role as well. * T050-new.sh: Breakpoint notmuch_database_add_message instead of add_file to the same effect, and avoid bad gdb behaviour on Travis CI. Amended by db: s/notmuch_database_add_message/notmuch_database_index_file/ Somehow the wrapper function doesn't work as a breakpoint; perhaps due to inlining.

test: require test_begin_subtest before test_expect_code

2017-03-09T13:03:40Z

Unify the subtests by requiring test_begin_subtest before test_expect_code. (Similar change for test_expect_success has already been done.) This increases clarity in the test scripts by having a separate line for the start of the subtest with the heading, and makes it possible to simplify the test infrastructure by making all subtests similar.

test: allow user to choose which gdb to run tests with

2017-01-08T14:50:28Z

The variable used for selecting gdb is TEST_GDB, consistent with TEST_CC and TEST_EMACS{,CLIENT}.

test: check the handling of files vanishing between scandir and indexing

2016-12-03T11:18:49Z

Add a file for scandir to find, but use gdb to remove it before it gets indexed.

lib: fix handling of one character long directory names at top level

2016-04-12T23:40:19Z

The code to skip multiple slashes in _notmuch_database_split_path() skips back one character too much. This is compensated by a +1 in the length parameter to the strndup() call. Mostly this works fine, but if the path is to a file under a top level directory with one character long name, the directory part is mistaken to be part of the file name (slash == path in code). The returned directory name will be the empty string and the basename will be the full path, breaking the indexing logic in notmuch new. Fix the multiple slash skipping to keep the slash variable pointing at the last slash, and adjust strndup() accordingly. The bug was introduced in commit e890b0cf4011fd9fd77ebd87343379e4a778888b Author: Carl Worth Date: Sat Dec 19 13:20:26 2009 -0800 database: Store the parent ID for each directory document. just a little over two months after the initial commit in the Notmuch code history, making this the longest living bug in Notmuch to date.

test: test one character long directory names at top level

2016-04-12T23:37:08Z

Yes, it's broken. Reported by h01ger on IRC.

test: cope with glass backend file naming variations

2016-04-12T23:21:09Z

In several places in the test suite we intentionally corrupt the Xapian database in order to test error handling. This corruption is specific to the on-disk organization of the database, and that changed with the glass backend. We use the previously computed default backend to make the tests adapt to changing names.

cli: fix function name in notmuch new debug logging

2015-12-30T15:28:30Z

add_files_recursive has been renamed add_files long ago.