notmuch/test/T050-new.sh, branch 0.35 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.35 2022-01-16T14:52:13Z cli/new: only ignore .notmuch at top level 2022-01-16T14:52:13Z David Bremner david@tethera.net 2021-12-26T12:24:10Z urn:sha1:6472dbf4b7fdec3bd59d7622ef477a035e34c67a Since the bug was first reported in [1], notmuch has gained the ability to have the database located outside the mail root, hence this this change differs slightly from Jani's proposed solution [2] in not using notmuch_database_get_path, but rather the already retrieved mail_root. [1]: id:87mwhifu9a.fsf@trouble.defaultvalue.org [2]: id:87ios5v59p.fsf@nikula.org test: add known broken test for ignoring non-toplevel .notmuch 2022-01-16T14:47:16Z David Bremner david@tethera.net 2021-12-26T12:24:09Z urn:sha1:fd6d50b38f8d8529191f6c9b637ecb458018baa3 In [1] Rob observed that notmuch new ignored directories called .notmuch everywhere in the tree, where they should only (and now, with split configs, at most) be ignored at the top level. Add a test to demonstrate the problem. [1]: id:87mwhifu9a.fsf@trouble.defaultvalue.org test/new: replace use of gdb in vanishing file test 2021-12-04T16:36:08Z David Bremner david@tethera.net 2021-10-25T01:15:15Z urn:sha1:efa7f35d4a28bd8af20cc5dee3195dc8f2d142bc Unlike the similar change in T060-new, no symlink creation is needed here. config: ignore leading/trailing spaces in ';'-delimited lists 2021-12-04T16:16:12Z David Bremner david@tethera.net 2021-09-30T17:17:48Z urn:sha1:bab633d3ac87167dc214094f9d340655885a01b1 In [1] Ciprian observed that it was easy for users to mistakenly introduce leading and trailing space to new.tags when editing a notmuch config file. This commit strips spaces on either side of the ';' delimiter when splitting. In principle it would be possible to support tags (or other config values) with leading or trailing spaces by processing '\s' escapes in the input string. Currently such processing is not done. [1]: id:CA+Tk8fzjPLaEd3vL1f9ebk_bF_RV8PDTLzDupraTkCLCpJAmCg@mail.gmail.com test: known broken tests for leading/trailing ws in config 2021-12-04T16:15:49Z David Bremner david@tethera.net 2021-09-30T17:17:47Z urn:sha1:e22bbb124e4f9191880e80d6517346f35bf7e2a9 These tests duplicate the bug/misfeature reported in id:CA+Tk8fzjPLaEd3vL1f9ebk_bF_RV8PDTLzDupraTkCLCpJAmCg@mail.gmail.com test: add known broken test for indexing RFC822 group names 2021-06-05T18:31:03Z David Bremner david@tethera.net 2021-03-24T00:24:05Z urn:sha1:2c85cc29bd8c29792acacc65cf9c5810d7f4791e Austin Clements diagnosed this indexing problem in [1]. [1]: id:20130711215207.GR2214@mit.edu lib/config: expand relative paths when reading from database 2021-05-10T14:12:58Z David Bremner david@tethera.net 2021-05-07T10:27:37Z urn:sha1:1040e7aa077197e5295180ef54576ea39c298a36 This makes the treatment of relative paths consistent between the database and config files. test: add known broken test for relative setting of mail_root 2021-05-10T14:11:42Z David Bremner david@tethera.net 2021-05-07T10:17:43Z urn:sha1:322a492c77725b265cb7f5c1d0bed5dee6999743 The behaviour should not change depending on where the configuration is stored. lib/config: canonicalize paths relative to $HOME. 2021-05-10T14:08:18Z David Bremner david@tethera.net 2021-05-07T00:16:38Z urn:sha1:31098c4ae40511ffda9788a6654adbf898063d7f Prior to 0.32, notmuch had the (undocumented) behaviour that it expanded a relative value of database.path with respect to $HOME. In 0.32 this was special cased for database.path but broken for database.mail_root, which causes problems for at least notmuch-new when database.path is set to a relative path. The change in T030-config.sh reflects a user visible, but hopefully harmless behaviour change; the expanded form of the paths will now be printed by notmuch config. test: add known broken test for relative database path in new 2021-05-10T14:06:40Z David Bremner david@tethera.net 2021-05-06T22:55:07Z urn:sha1:ef0b1266190141b108a338ba06348e335ec4957b This test highlights a bug introduced in 0.32. The new split between path and mail_root does not properly canonicalize relative paths in the latter.