notmuch/test/T050-new.sh, branch debian/stretch

lib: fix handling of one character long directory names at top level

2016-04-12T23:40:19Z

The code to skip multiple slashes in _notmuch_database_split_path() skips back one character too much. This is compensated by a +1 in the length parameter to the strndup() call. Mostly this works fine, but if the path is to a file under a top level directory with one character long name, the directory part is mistaken to be part of the file name (slash == path in code). The returned directory name will be the empty string and the basename will be the full path, breaking the indexing logic in notmuch new. Fix the multiple slash skipping to keep the slash variable pointing at the last slash, and adjust strndup() accordingly. The bug was introduced in commit e890b0cf4011fd9fd77ebd87343379e4a778888b Author: Carl Worth Date: Sat Dec 19 13:20:26 2009 -0800 database: Store the parent ID for each directory document. just a little over two months after the initial commit in the Notmuch code history, making this the longest living bug in Notmuch to date.

test: test one character long directory names at top level

2016-04-12T23:37:08Z

Yes, it's broken. Reported by h01ger on IRC.

test: cope with glass backend file naming variations

2016-04-12T23:21:09Z

In several places in the test suite we intentionally corrupt the Xapian database in order to test error handling. This corruption is specific to the on-disk organization of the database, and that changed with the glass backend. We use the previously computed default backend to make the tests adapt to changing names.

cli: fix function name in notmuch new debug logging

2015-12-30T15:28:30Z

add_files_recursive has been renamed add_files long ago.

cli: delete directory documents on directory removal

2015-10-14T10:55:41Z

There was a problem with the directory documents being left behind when the filesystem directory was removed. This was worked around in [1]. However, that ignored the fact that the directory documents are also still listed by notmuch_directory_get_child_directories() leading to confusing results when running notmuch new. The directory documents are found and queued for removal over and over again. Fix the problem for real by removing the directory documents. This fixes the tests flagged as broken in [2]. The (non-deterministic) hack test from [3] also still passes with this change. [1] commit acd66cdec075312944e527febd46382e54d99367 [2] commit ed9ceda623d3f22fb66365b33db63c5c982067d3 [3] id:1441445731-4362-1-git-send-email-jani@nikula.org

test: flag one more notmuch new test as broken

2015-10-10T12:13:02Z

Drop the test update added in [1] and mark the test as broken, like the tests flagged as broken in [2]. These all reflect the same underlying breakage with (lack of) directory deletion. [1] commit e4e04bbc328f990e36b77f508aef904d156029b1 [2] commit ed9ceda623d3f22fb66365b33db63c5c982067d3

test: make script exit (1) if it "fails" to source (.) a file

2015-08-07T19:56:39Z

The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero.

test: add debugging output to notmuch-new tests, mark 5 as broken

2015-08-04T19:00:09Z

I marked the tests where I really couldn't understand the output as broken. It could also be that I don't understand how directory removal is supposed to work.

cli/new: add more debugging output

2015-08-04T18:59:58Z

Try to narrow down what part of the code adds files and directories to the queue(s) to be deleted. Update one test. The output is slightly confusing, but I believe it is correct, resulting from a directory being discovered but containing only ignored files.

test: don't claim single message mbox support is going away

2015-08-04T18:59:50Z

We gave up on this.