notmuch/test/T070-insert.sh, branch 0.26_rc2

test: test notmuch insert --folder=""

2017-11-08T14:47:14Z

Test insert into top level folder.

test: use $(dirname "$0") for sourcing test-lib.sh

2017-10-20T22:52:49Z

Don't assume the tests are always run from within the source tree.

database: add n_d_index_file (deprecates n_d_add_message)

2017-08-23T10:38:37Z

We need a way to pass parameters to the indexing functionality on the first index, not just on reindexing. The obvious place is in notmuch_database_add_message. But since modifying the argument list would break both API and ABI, we needed a new name. I considered notmuch_database_add_message_with_params(), but the functionality we're talking about doesn't always add a message. It tries to index a specific file, possibly adding a message, but possibly doing other things, like adding terms to an existing message, or failing to deal with message objects entirely (e.g. because the file didn't contain a message). So i chose the function name notmuch_database_index_file. I confess i'm a little concerned about confusing future notmuch developers with the new name, since we already have a private _notmuch_message_index_file function, and the two do rather different things. But i think the added clarity for people linking against the future libnotmuch and the capacity for using index parameters makes this a worthwhile tradeoff. (that said, if anyone has another name that they strongly prefer, i'd be happy to go with it) This changeset also adjusts the tests so that we test whether the new, preferred function returns bad values (since the deprecated function just calls the new one). We can keep the deprecated n_d_add_message function around as long as we like, but at the next place where we're forced to break API or ABI we can probably choose to drop the name relatively safely. NOTE: there is probably more cleanup to do in the ruby and go bindings to complete the deprecation directly. I don't know those languages well enough to attempt a fix; i don't know how to test them; and i don't know the culture around those languages about API additions or deprecations.

insert: strip trailing / in folder path

2017-08-22T21:48:09Z

This patch fixes the "Insert message into folder with trailing /" test. The problem was insufficient path canonization. From database's point of view, "Sent" and "Sent/" are different folders. If user runs (note the last '/'): notmuch insert --folder=maildir/Sent/ < test.msg notmuch will create an extra XDIRECTORY record for the folder 'Sent/'. This means that database will have _TWO_ records for _ONE_ physical folder: 'Sent' and 'Sent/'. However, the 'notmuch new' command will update only records related to the first one (the correct one). Now, if user moved the email file (e.g. from 'Sent/new' to 'Sent/cur'), 'notmuch new' will add a record about the new file, but will not delete the old record. Signed-off-by: Yuri Volchkov

test: insert into the folder with trailing /

2017-08-20T11:28:55Z

From database's point of view, "Drafts" and "Drafts/" are different folders Signed-off-by: Yuri Volchkov Amended: add test_subtest_known_broken (db)

test: require test_begin_subtest before test_expect_code

2017-03-09T13:03:40Z

Unify the subtests by requiring test_begin_subtest before test_expect_code. (Similar change for test_expect_success has already been done.) This increases clarity in the test scripts by having a separate line for the start of the subtest with the heading, and makes it possible to simplify the test infrastructure by making all subtests similar.

cli/show: list all filenames of a message in the formatted output

2017-02-26T11:41:33Z

Instead of just having the first filename for the message, list all duplicate filenames of the message as a list in the formatted outputs. This bumps the format version to 3.

test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace

2017-01-28T02:02:36Z

Some new unwrapped 'wc -l's have been added since Jani's 60e79e3a9f1c8

test: allow user to choose which gdb to run tests with

2017-01-08T14:50:28Z

The variable used for selecting gdb is TEST_GDB, consistent with TEST_CC and TEST_EMACS{,CLIENT}.

cli/insert: return EX_TEMPFAIL for some errors

2016-12-07T11:00:40Z

Attempt to distinguish between errors indicating misconfiguration or programmer error, which we consider "permanent", in the sense that automatic retries are unlikely to be useful, and those indicating transient error conditions. We consider XAPIAN_EXCEPTION transient because it covers the important special case of locking failure.