notmuch/test/T070-insert.sh, branch 0.33

test: trivial style cleanups

2021-05-17T10:27:52Z

Signed-off-by: Felipe Contreras

test: clean up some extra whitespace.

2021-03-12T11:19:14Z

The extra space is mainly just untidy.

CLI/insert: convert to new config framework.

2021-02-06T23:17:34Z

The new talloc context is needed to run the hook at the very end of the function. That in turn is needed so that this process gives up the write lock on the database.

test: fix syntax errors in erroring calls to notmuch insert

2020-09-05T00:04:33Z

notmuch insert does not currently support passing a filename for the input, so all of these tests have an extra error in addition to the one being tested for. Currently this does not make a difference because the error being tested for is caught before the error of an extra command line argument. In the future it might make a difference, and in any case it is confusing.

test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

2019-06-29T19:11:08Z

This removes the dependency of this test script on gdb, and considerably speeds up the running of the tests. Signed-off-by: Daniel Kahn Gillmor

cli/show: emit new whole-message crypto status output

2019-05-26T11:20:23Z

This allows MUAs that don't want to think about per-mime-part cryptographic status to have a simple high-level overview of the message's cryptographic state. Sensibly structured encrypted and/or signed messages will work fine with this. The only requirement for the simplest encryption + signing is that the message have all of its encryption and signing protection (the "cryptographic envelope") in a contiguous set of MIME layers at the very outside of the message itself. This is because messages with some subparts signed or encrypted, but with other subparts with no cryptographic protection is very difficult to reason about, and even harder for the user to make sense of or work with. For further characterization of the Cryptographic Envelope and some of the usability tradeoffs, see here: https://dkg.fifthhorseman.net/blog/e-mail-cryptography.html#cryptographic-envelope

cli/insert: add --world-readable flag

2018-03-24T23:08:11Z

In some cases (e.g. when building a publicly-visible e-mail archive) it doesn't make any sense to restrict visibility of the message to the current user account. This adds a --world-readable boolean option for "notmuch insert", so that those who want to archive their mail publicly can feed their archiver with: notmuch insert --world-readable Other local delivery agents (postfix's local, and dovecot's lda) all default to delivery in mode 0600 rather than relying on the user's umask, so this fix doesn't change the default. Also, this does not override the user's umask. if the umask is already set tight, it will not become looser as the result of passing --world-readable. Signed-off-by: Daniel Kahn Gillmor

test: test notmuch insert --folder=""

2017-11-08T14:47:14Z

Test insert into top level folder.

test: use $(dirname "$0") for sourcing test-lib.sh

2017-10-20T22:52:49Z

Don't assume the tests are always run from within the source tree.

database: add n_d_index_file (deprecates n_d_add_message)

2017-08-23T10:38:37Z

We need a way to pass parameters to the indexing functionality on the first index, not just on reindexing. The obvious place is in notmuch_database_add_message. But since modifying the argument list would break both API and ABI, we needed a new name. I considered notmuch_database_add_message_with_params(), but the functionality we're talking about doesn't always add a message. It tries to index a specific file, possibly adding a message, but possibly doing other things, like adding terms to an existing message, or failing to deal with message objects entirely (e.g. because the file didn't contain a message). So i chose the function name notmuch_database_index_file. I confess i'm a little concerned about confusing future notmuch developers with the new name, since we already have a private _notmuch_message_index_file function, and the two do rather different things. But i think the added clarity for people linking against the future libnotmuch and the capacity for using index parameters makes this a worthwhile tradeoff. (that said, if anyone has another name that they strongly prefer, i'd be happy to go with it) This changeset also adjusts the tests so that we test whether the new, preferred function returns bad values (since the deprecated function just calls the new one). We can keep the deprecated n_d_add_message function around as long as we like, but at the next place where we're forced to break API or ABI we can probably choose to drop the name relatively safely. NOTE: there is probably more cleanup to do in the ruby and go bindings to complete the deprecation directly. I don't know those languages well enough to attempt a fix; i don't know how to test them; and i don't know the culture around those languages about API additions or deprecations.