thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.28.3 2018-09-06T11:07:13Z 2018-09-06T11:07:13Z David Bremner david@tethera.net 2018-08-30T11:29:15Z urn:sha1:87934c432c4bee9df09f268a3f05933c59c2caf1 As reported by Sean Whitton, there are mailers (in particular the Debian Bug Tracking System) that have sensible In-Reply-To headers, but un-useful-for-notmuch References (in particular with the BTS, the oldest reference is last). I looked at a sample of about 200K messages, and only about 0.5% these had something other than a single message-id in In-Reply-To. On this basis, if we see a single message-id in In-Reply-To, consider that as authoritative. 2018-09-06T11:07:13Z David Bremner david@tethera.net 2018-08-30T11:29:12Z urn:sha1:35053c2b9af0eb7ce5bd612c642163275490513a In a future commit, we will start trusting In-Reply-To's when they look sane (i.e. a single message-id). Modify these tests so they will keep passing (i.e. keep choosing References) when that happens. 2018-09-06T11:07:13Z David Bremner david@tethera.net 2018-08-30T11:29:11Z urn:sha1:ea08032ae40119b24ef22c1c30aaf631cda02dd0 The current scheme of choosing the replyto (i.e. the default parent for threading purposes) does not work well for mailers that put the oldest Reference last. 2018-09-06T11:07:13Z David Bremner david@tethera.net 2018-08-30T11:29:10Z urn:sha1:46dce33abc82ea6ebd3be2e0887506af4185c739 We (finally) implement the XXX comment. It requires a bit of care not to reparent all of the possible toplevel messages. _notmuch_messages_has_next is not ready to be a public function yet, since it punts on the mset case. We know in the one case it is called, the notmuch_messages_t is just a regular list / iterator. 2018-09-06T11:07:13Z David Bremner david@tethera.net 2018-08-30T11:29:07Z urn:sha1:a33085828408ec421bcfcf23449b51e0a0e3cece This is mainly to lay out the structure of the final code. The problem isn't really solved yet, although some very simple cases are better (hence the fixed test). We need two passes through the messages because we need to be careful not to re-parent too many messages and end up without any toplevel messages. 2018-09-06T11:07:12Z David Bremner david@tethera.net 2018-08-30T11:29:04Z urn:sha1:9b568e73e1afc211306d18dac3d27df4a07a0fdd For non-root messages, this should not should anything currently, as the messages are already added in date order. In the future we will add some non-root messages in a second pass out of order and the sorting will be useful. It does fix the order of multiple root-messages (although it is overkill for that). 2018-09-06T11:07:12Z David Bremner david@tethera.net 2018-08-30T11:29:03Z urn:sha1:ccb52edb4c9fecd65a5a2577b6d1e96c4b8de492 This documents the bug discussed at id:87efgmmysi.fsf@len.workgroup The underlying issue is that the reply to a ghost (missing) message is falsely classified as a root message in _resolve_thread_relationships. There are two pairs of tests; in each case the the first test is simpler / more robust, but also easier to fool. 2017-10-20T22:52:49Z Jani Nikula jani@nikula.org 2017-09-25T20:38:19Z urn:sha1:a863de1e43ee34f6f5794a2759fdceb287e851aa Don't assume the tests are always run from within the source tree. 2017-02-26T11:41:33Z Jani Nikula jani@nikula.org 2017-02-25T13:31:31Z urn:sha1:14c60cf168ac3b0f277188c16e6012b7ebdadde7 Instead of just having the first filename for the message, list all duplicate filenames of the message as a list in the formatted outputs. This bumps the format version to 3. 2015-08-07T19:56:39Z Tomi Ollila tomi.ollila@iki.fi 2015-08-06T09:13:36Z urn:sha1:02a2eeb427d6b424029f6e5e5ddad4c6ec987741 The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero.