notmuch/test/T520-show.sh, branch 0.26 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.26 2017-10-20T22:52:49Z test: use $(dirname "$0") for sourcing test-lib.sh 2017-10-20T22:52:49Z Jani Nikula jani@nikula.org 2017-09-25T20:38:19Z urn:sha1:a863de1e43ee34f6f5794a2759fdceb287e851aa Don't assume the tests are always run from within the source tree. test: make script exit (1) if it "fails" to source (.) a file 2015-08-07T19:56:39Z Tomi Ollila tomi.ollila@iki.fi 2015-08-06T09:13:36Z urn:sha1:02a2eeb427d6b424029f6e5e5ddad4c6ec987741 The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero. notmuch-show: detect NULL pointer returned from notmuch_query_search_threads 2014-01-25T00:24:11Z David Bremner david@tethera.net 2014-01-23T12:24:01Z urn:sha1:ecbb29e8cea404faab2ef55b06431942ee329941 We want to return an error status, not 0 or (worse) segfault. test: add known broken test exit code of notmuch show 2014-01-25T00:19:50Z David Bremner david@tethera.net 2014-01-23T12:23:59Z urn:sha1:5c526d1737212dd736b1c3fedc6bf5b3493ce436 This test catches a segfault on a syntactically invalid query. It also catches a problem with my initial fix, which still returned 0.