thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.28.3 2017-10-20T22:52:49Z 2017-10-20T22:52:49Z Jani Nikula jani@nikula.org 2017-09-25T20:38:19Z urn:sha1:a863de1e43ee34f6f5794a2759fdceb287e851aa Don't assume the tests are always run from within the source tree. 2017-08-23T10:38:37Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2017-08-17T23:14:25Z urn:sha1:b10ce6bc23002d48916b1b2f375480e7540e3164 We need a way to pass parameters to the indexing functionality on the first index, not just on reindexing. The obvious place is in notmuch_database_add_message. But since modifying the argument list would break both API and ABI, we needed a new name. I considered notmuch_database_add_message_with_params(), but the functionality we're talking about doesn't always add a message. It tries to index a specific file, possibly adding a message, but possibly doing other things, like adding terms to an existing message, or failing to deal with message objects entirely (e.g. because the file didn't contain a message). So i chose the function name notmuch_database_index_file. I confess i'm a little concerned about confusing future notmuch developers with the new name, since we already have a private _notmuch_message_index_file function, and the two do rather different things. But i think the added clarity for people linking against the future libnotmuch and the capacity for using index parameters makes this a worthwhile tradeoff. (that said, if anyone has another name that they strongly prefer, i'd be happy to go with it) This changeset also adjusts the tests so that we test whether the new, preferred function returns bad values (since the deprecated function just calls the new one). We can keep the deprecated n_d_add_message function around as long as we like, but at the next place where we're forced to break API or ABI we can probably choose to drop the name relatively safely. NOTE: there is probably more cleanup to do in the ruby and go bindings to complete the deprecation directly. I don't know those languages well enough to attempt a fix; i don't know how to test them; and i don't know the culture around those languages about API additions or deprecations. 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:34Z urn:sha1:5ce8e0b11b40f733e6231d2067764e76717a341a This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. One or two remaining uses of the (removed) non-status returning version fixed at the same time 2017-03-22T11:35:07Z David Bremner david@tethera.net 2017-02-26T21:21:32Z urn:sha1:86cbd215eb67d7b996c977352a50e70c101cb641 This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name. 2017-03-09T13:01:21Z Jani Nikula jani@nikula.org 2017-02-26T13:43:00Z urn:sha1:d0cd253b37646d9364d046e1d3edb022a58c105a Unify the subtests by requiring test_begin_subtest before test_expect_success. (Similar change for test_expect_code will follow.) This increases clarity in the test scripts by having a separate line for the start of the subtest with the heading, and makes it possible to simplify the test infrastructure by making all subtests similar. 2016-04-12T23:21:09Z David Bremner david@tethera.net 2016-04-09T01:49:50Z urn:sha1:e311aad182326a1dcb0f8512e10b0e0f0faa9e2c In several places in the test suite we intentionally corrupt the Xapian database in order to test error handling. This corruption is specific to the on-disk organization of the database, and that changed with the glass backend. We use the previously computed default backend to make the tests adapt to changing names. 2016-04-12T23:04:03Z David Bremner david@tethera.net 2016-04-09T01:49:47Z urn:sha1:45df509cb6fd642bc5895f2c7869a354c1255f4b There is at least one bug fixed here (missing parameter to printf), even if exiting via segfault is considered OK. 2016-01-27T02:50:58Z David Bremner david@tethera.net 2016-01-23T12:49:26Z urn:sha1:12534d5c4b02498173b0c63d063ae0a3c845b957 test_C and notmuch_search_files_sanitize were giving different output on the same path, which is not technically wrong, but slightly confusing. 2015-09-04T11:22:42Z David Bremner david@tethera.net 2015-06-07T15:01:59Z urn:sha1:9ee29ad6f0805dc55e63f8a04a68a1f55d0c382b The plan is to re-use them in testing the same errors from the CLI 2015-08-07T19:56:39Z Tomi Ollila tomi.ollila@iki.fi 2015-08-06T09:13:36Z urn:sha1:02a2eeb427d6b424029f6e5e5ddad4c6ec987741 The files (test) scripts source (with builtin command `.`) provides information which the scripts depend, and without the `source` to succeed allowing script to continue may lead to dangerous situations (e.g. rm -rf "${undefined_variable}"/*). At the end of all source (.) lines construct ' || exit 1' was added; In our case the script script will exit if it cannot find (or read) the file to be sourced. Additionally script would also exits if the last command of the sourced file exited nonzero.