notmuch/test/T560-lib-error.sh, branch nmweb thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=nmweb 2022-09-03T11:24:43Z lib/open: create database path in some cases 2022-09-03T11:24:43Z David Bremner david@tethera.net 2022-07-29T11:31:37Z urn:sha1:84e4e130e2c920b3dee91901582c4ab6276e2630 There is some duplication of code here, but not all of the locations valid to find a database make sense to create. Furthermore we nead two passes, so the control flow in _choose_database_path would get a bit convoluted. lib/open: return non-SUCCESS on missing database path 2022-09-03T11:24:43Z David Bremner david@tethera.net 2022-07-29T11:23:11Z urn:sha1:8ba3057d01b11fb806581f8dc451a8891a4d4e0e This simplifies the logic of creating the directory path when it doesn't exist. test: add known broken test for notmuch_tags_valid (NULL) 2022-06-25T19:05:32Z David Bremner david@tethera.net 2022-05-25T10:51:13Z urn:sha1:00ec2b271d457bf7b81efed8ff91e52290a38f4a This should return false, but currently segfaults. Start a new file for tags library API related tests. This is maybe overkill, but new C boilerplate which doesn't corrupt the database is needed anyway. test: replace deprecated use of notmuch_database_create 2022-05-29T10:36:59Z David Bremner david@tethera.net 2022-05-21T18:06:31Z urn:sha1:eab665c573155237001f42ca3bcefc0f7b9281a5 Like notmuch_database_open, we need to conditionally print the error message. test: replace deprecated use of notmuch_database_open 2022-05-29T10:36:44Z David Bremner david@tethera.net 2022-05-21T18:06:30Z urn:sha1:32f299fe137a4ac731750d576e65337b395a42ef This is a bit more involved than replacing the use of notmuch_database_open_verbose, as we have to effectively inline the definition of notmuch_database_open. test: replace deprecated use of notmuch_database_open_verbose 2022-05-29T10:36:32Z David Bremner david@tethera.net 2022-05-21T18:06:29Z urn:sha1:f6e7a9dde5a7d9c2fa390a15888704c31852a538 We need to do it some day, and it is a bit annoying to read deprecation messages in broken tests. lib/open: restore default database path of $HOME/mail 2021-05-15T11:40:05Z David Bremner david@tethera.net 2021-05-10T10:39:18Z urn:sha1:b3258244c84a7673db39c46cad96ddb63b131dae Although this default worked for "notmuch config get", it didn't work most other places. Restore the previous functionality, with the wrinkle that XDG locations will shadow $HOME/mail if they exist. This fixes a bug reported by Jack Kamm in id:87eeefdc8b.fsf@gmail.com lib/open: support XDG_DATA_HOME as a fallback database location. 2021-03-20T10:43:09Z David Bremner david@tethera.net 2021-01-04T00:04:46Z urn:sha1:c82554193d0a0c288ad49e3d4fb8c949b92f71fa This changes some error reporting, either intentionally by reporting the highest level missing directory, or by side effect from looking in XDG locations when given null database location. lib/open: reuse directory checks from n_d_c_with_config 2021-03-20T10:24:59Z David Bremner david@tethera.net 2021-03-04T13:31:13Z urn:sha1:cba540d6f5cbbad282a3046ed00a7966238fa14d Make checks more uniform between creating new databases and opening existing ones. lib: introduce notmuch_database_create_with_config 2021-02-06T23:48:34Z David Bremner david@tethera.net 2021-01-02T00:43:14Z urn:sha1:ac67cd84eea1148680ab3a377d35ae346073f138 This takes a config path parameter, and can use that to decide the new database location.