notmuch/test/T566-lib-message.sh, branch 0.37 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.37 2022-06-25T19:06:34Z lib: check for writable db in n_m_tags_maildir_flags 2022-06-25T19:06:34Z David Bremner david@tethera.net 2022-05-25T10:51:17Z urn:sha1:6f749dd24a1c8138a05ac92884e8cb71098c7f6e The database needs to be writable because the list of stored file names will change in general. lib: add NOTMUCH_STATUS_CLOSED_DATABASE, use in _n_d_ensure_writable 2022-06-25T19:06:18Z David Bremner david@tethera.net 2022-05-25T10:51:16Z urn:sha1:3f27cce71f9f154cb0c2134c32d41c31eb62a239 In order for a database to actually be writeable, it must be the case that it is open, not just the correct type of Xapian object. By explicitely checking, we are able to provide better error reporting, in particular for the previously broken test in T566-lib-message. test: error handling for n_m_tags_to_maildir_flags 2022-06-25T19:05:16Z David Bremner david@tethera.net 2022-05-25T10:51:12Z urn:sha1:8ade833ec2714c6f4fb2fcba0bc28b9c421907d5 The closed database case should fail gracefully, but currently it segfaults. test: error handling in _n_message_{add,remove}_filename 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:39:01Z urn:sha1:9e9d0e5ffcdb92e4051b10a8df0c093db1be5d42 Use a closed database to force throwing a Xapian exception. Leave the check vague to accomodate a potential explicit check for open database. test: _notmuch_message_remove_term catches exceptions. 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:38:56Z urn:sha1:a581755fbbf4149c33740779a85f3ee1f11cd7e9 Unfortunately we can't differentiate between the two distinct error conditions for Document::remove_term. lib/message: catch exceptions in _n_m_add_term 2022-06-25T15:55:02Z David Bremner david@tethera.net 2022-05-23T23:38:55Z urn:sha1:f48d2e2ff89a7e0a413b29ca844b2c785063eb3d Some code movement is needed to make sure the cache is only invalidated when the Xapian operation succeeds. test: replace deprecated use of notmuch_database_open_verbose 2022-05-29T10:36:32Z David Bremner david@tethera.net 2022-05-21T18:06:29Z urn:sha1:f6e7a9dde5a7d9c2fa390a15888704c31852a538 We need to do it some day, and it is a bit annoying to read deprecation messages in broken tests. test: move system includes to notmuch-test.h 2021-12-04T16:36:08Z David Bremner david@tethera.net 2021-10-28T12:32:34Z urn:sha1:1643c0459a496b45b601d91e0089fac507a2a6d1 This removes some redudant includes, and will also make it easier to introduce "#define _GNU_SOURCE", which must come before all system includes. test: clean up some extra whitespace. 2021-03-12T11:19:14Z David Bremner david@tethera.net 2021-01-16T01:29:17Z urn:sha1:97fadd0645e908ff8322577a983dc710bfda33d6 The extra space is mainly just untidy. test: regression test for n_m_get_filenames 2020-08-03T23:50:15Z David Bremner david@tethera.net 2020-08-01T12:25:53Z urn:sha1:c151506773e76345508af8e46d7787d73fcffc62 Closing the database after the iterator is created is not a problem.