notmuch/test/T590-libconfig.sh, branch 0.36thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=0.362022-01-18T12:09:14Zlib/config: add known config key "show.extra_headers"2022-01-18T12:09:14ZDavid Bremnerdavid@tethera.net2022-01-01T12:01:35Zurn:sha1:79936ac93e486d8ff82729840154bf8c2212ebb6
Used in a following commit to enable including extra headers beyond
the default in structured output.
lib/open: no default mail root in split configurations2022-01-15T19:59:39ZDavid Bremnerdavid@tethera.net2021-12-25T13:33:05Zurn:sha1:fad2e7540bf9309bfb335650ded753e9ed085eff
If we know the configuration is split, but there is no mail root
defined, this indicates a (lack of) configuration error. Currently
this can only arise in XDG configurations.
test/libconfig: add two tests for the config = "" case2022-01-15T19:49:14ZDavid Bremnerdavid@tethera.net2021-12-11T12:49:12Zurn:sha1:237f803fdbf8978514d0f6b56e9d1aaf51cb3153
If notmuch_database_open_with_config finds a database, but that
database is not in a legacy, non-split configuration, then it
currently incorrectly deduces the mail root and returns SUCCESS. Add
to two tests to demonstrate this bug.
test/libconfig: save and restore config file2022-01-15T19:49:00ZDavid Bremnerdavid@tethera.net2021-12-11T12:49:11Zurn:sha1:c62ebcfea9ee4868a98b3889711a0fdd3f842605
Currently the config file is unusable for further tests requiring a
valid database path.
test: move system includes to notmuch-test.h2021-12-04T16:36:08ZDavid Bremnerdavid@tethera.net2021-10-28T12:32:34Zurn:sha1:1643c0459a496b45b601d91e0089fac507a2a6d1
This removes some redudant includes, and will also make it easier to
introduce "#define _GNU_SOURCE", which must come before all system
includes.
config: ignore leading/trailing spaces in ';'-delimited lists2021-12-04T16:16:12ZDavid Bremnerdavid@tethera.net2021-09-30T17:17:48Zurn:sha1:bab633d3ac87167dc214094f9d340655885a01b1
In [1] Ciprian observed that it was easy for users to mistakenly
introduce leading and trailing space to new.tags when editing a
notmuch config file. This commit strips spaces on either side of the
';' delimiter when splitting.
In principle it would be possible to support tags (or other config
values) with leading or trailing spaces by processing '\s' escapes in
the input string. Currently such processing is not done.
[1]: id:CA+Tk8fzjPLaEd3vL1f9ebk_bF_RV8PDTLzDupraTkCLCpJAmCg@mail.gmail.com
test: known broken tests for leading/trailing ws in config2021-12-04T16:15:49ZDavid Bremnerdavid@tethera.net2021-09-30T17:17:47Zurn:sha1:e22bbb124e4f9191880e80d6517346f35bf7e2a9
These tests duplicate the bug/misfeature reported in
id:CA+Tk8fzjPLaEd3vL1f9ebk_bF_RV8PDTLzDupraTkCLCpJAmCg@mail.gmail.com
lib/config: don't overwrite database.path if the caller passed it2021-12-04T00:52:11ZDavid Bremnerdavid@tethera.net2021-10-28T01:34:19Zurn:sha1:59aac9cef37a9937bdf2265078d063673111f80b
If the user passed a path, and we opened it, then we consider that
definitive definition of "database.path". This makes libnotmuch
respond more gracefully to certain erroneous combinations of
NOTMUCH_CONFIG settings and config file contents.
test: add known broken test for conflict with database parameter2021-12-04T00:49:36ZDavid Bremnerdavid@tethera.net2021-10-28T01:34:17Zurn:sha1:378415a55762ff0222e3de6a2e20a9823ce1d07e
This is arguably user error: having configuration file with bad
settings in it (and/or having a bad NOTMUCH_CONFIG environment
variable). On the other hand returning a different path than was
actually opened is definitely a bug.
test/libconfig: use 'export' for remaining sets of NOTMUCH_CONFIG2021-12-04T00:47:05ZDavid Bremnerdavid@tethera.net2021-12-04T00:47:05Zurn:sha1:59a778ae4bae182101c43f1acde08452a6542299
It makes the tests easier to understand if we always use export for
environment variables.