notmuch/test/T610-message-property.sh, branch masterthread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=master2025-02-22T10:59:48Ztest/message-property: convert python tests from legacy bindings2025-02-22T10:59:48ZDavid Bremnerdavid@tethera.net2025-02-15T19:22:53Zurn:sha1:58ea60c2e49fb7881046829141a7a795d1a3ffca
One test is deleted since that method is not provided by the new
bindings. Similar things can be done by accessing the PropertiesMap
returned by properties.
This change is a prelude to removing the legacy bindings from the build.
test: add test for notmuch_message_remove_all_properties_with_prefix2023-03-30T11:07:57ZKevin Boulainkevin@boula.in2023-03-29T16:13:33Zurn:sha1:a95959c491cc9ed7ca1493272b3fa91313f75041
It wasn't covered, though it shares most of its implementation with
notmuch_message_remove_all_properties.
lib/message-property: sync removed properties to the database2023-03-30T11:01:09ZKevin Boulainkevin@boula.in2023-03-29T16:13:32Zurn:sha1:fb55ff28a2fdaa9c218af5ca10b1cae674869edd
_notmuch_message_remove_all_properties wasn't syncing the message back
to the database but was still invalidating the metadata, giving the
impression the properties had actually been removed.
Also move the metadata invalidation to _notmuch_message_remove_terms
to be closer to what's done in _notmuch_message_modify_property and
_notmuch_message_remove_term.
test: reveal notmuch_message_remove_all_properties as broken2023-03-30T10:56:17ZDavid Bremnerdavid@tethera.net2023-03-30T10:56:17Zurn:sha1:336334996750240608d5f29ed5dd8e40a69c4d79
Close and re-open the database to show that the removal is not
committed to the database.
test: reorganize tests and mark a few of them as broken2023-03-30T10:49:07ZKevin Boulainkevin@boula.in2023-03-29T16:13:31Zurn:sha1:e191d3c574e91199e524acbf6d7199bd58fd73d5
notmuch_message_remove_all_properties should have removed the
testkey1 = testvalue1
property but hasn't. Delay the execution of the corresponding test
to avoid updating a few tests that actually relied on the broken
behavior.
test: remove unnecessary sorting2023-03-30T10:48:27ZKevin Boulainkevin@boula.in2023-03-29T16:13:30Zurn:sha1:552d9ec9f766762ffdd1f565fc88b0a980f15b39
The other tests rely on a stable output.
test: display key name in property tests2023-03-30T10:48:19ZKevin Boulainkevin@boula.in2023-03-29T16:13:29Zurn:sha1:ce59df52968d661bc5a173f75a37f27d290d955b
To make the tests a bit easier to understand.
lib/message-property: catch xapian exceptions2023-03-30T10:08:47ZKevin Boulainkevin@boula.in2023-03-29T16:19:58Zurn:sha1:568f6bc3c2fd2396c05d254e2649750fb82b00b6
Since libnotmuch exposes a C interface there's no way for clients to
catch this.
Inspired by what's done for tags (see notmuch_message_remove_tag).
test: uncaught exception when editing properties of a removed message2023-03-30T10:06:48ZKevin Boulainkevin@boula.in2023-03-29T16:19:57Zurn:sha1:c810312e24067a7176a26b35893cf64f754886c5
These two functions don't fail gracefully when editing a removed
message:
BROKEN edit property on removed message without uncaught exception
--- T610-message-property.20.EXPECTED 2023-02-27 11:33:25.792764376 +0000
+++ T610-message-property.20.OUTPUT 2023-02-27 11:33:25.793764381 +0000
@@ -1,2 +1,3 @@
== stdout ==
== stderr ==
+terminate called after throwing an instance of 'Xapian::DocNotFoundError'
The other functions appear to be safe.
test: replace deprecated use of notmuch_database_open2022-05-29T10:36:44ZDavid Bremnerdavid@tethera.net2022-05-21T18:06:30Zurn:sha1:32f299fe137a4ac731750d576e65337b395a42ef
This is a bit more involved than replacing the use of
notmuch_database_open_verbose, as we have to effectively inline the
definition of notmuch_database_open.