notmuch/test/T640-database-modified.sh, branch 0.37_rc0

test: replace deprecated use of notmuch_database_open

2022-05-29T10:36:44Z

This is a bit more involved than replacing the use of notmuch_database_open_verbose, as we have to effectively inline the definition of notmuch_database_open.

test: move system includes to notmuch-test.h

2021-12-04T16:36:08Z

This removes some redudant includes, and will also make it easier to introduce "#define _GNU_SOURCE", which must come before all system includes.

test: use $(dirname "$0") for sourcing test-lib.sh

2017-10-20T22:52:49Z

Don't assume the tests are always run from within the source tree.

lib: replace deprecated n_q_search_messages with status returning version

2017-03-22T11:35:07Z

This function was deprecated in notmuch 0.21. We re-use the name for a status returning version, and deprecate the _st name.

test: make T640 compatible with old C compilers

2017-02-26T12:16:45Z

Apparently our test system does not use the same flags for compiling tests as it does for compiling notmuch. Make the test compatible with C89. Also remove one unused loop index.

lib: handle DatabaseModifiedError in _n_message_ensure_metadata

2017-02-26T01:13:50Z

The retries are hardcoded to a small number, and error handling aborts than propagating errors from notmuch_database_reopen. These are both somewhat justified by the assumption that most things that can go wrong in Xapian::Database::reopen are rare and fatal. Here's the brief discussion with Xapian upstream: 24-02-2017 08:12:57 < bremner> any intuition about how likely Xapian::Database::reopen is to fail? I'm catching a DatabaseModifiedError somewhere where handling any further errors is tricky, and wondering about treating a failed reopen as as "the impossible happened, stopping" 24-02-2017 16:22:34 < olly> bremner: there should not be much scope for failure - stuff like out of memory or disk errors, which are probably a good enough excuse to stop

test: add known broken test for uncaught DatabaseModifiedError

2017-02-26T01:07:18Z

There are several of these to track down, but one that is in quite a few code paths is _notmuch_message_ensure_metadata.