notmuch/test/maildir-sync, branch 0.6

test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability

2011-05-27T21:03:28Z

Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way systems running on bash < 4 can prepend bash >= 4 to path before running the tests.

tags_to_maildir_flags: Fix to preserve existing, unsupported flags

2010-11-12T00:36:02Z

This is to prevent notmuch from destroying any information the user has encoded as flags in the maildir filename. Tests are also added to the test suite to verify the documented behavior.

notmuch_message_tags_to_maildir_flags: Do nothing outside of "new" and "cur"

2010-11-11T22:32:17Z

Some people use notmuch with non-maildir files, (for example, email messages in MH format, or else cool things like using sluk[*] to suck down feeds into a format that notmuch can index). To better support uses like that, don't do any renaming for files that are not in a directory named either "new" or "cur". [*] https://github.com/krl/sluk/

Enable maildir synchronization by default.

2010-11-11T12:11:21Z

This is a useful feature that most people should want, so enable it by default, (still allowing customization to disable it of course).

test: Drop test for propagating flag changes from one file to another

2010-11-11T11:47:11Z

There's nothing in the current API documentation that would suggest the behavior being tested here. Attempt to implement this could have some nasty side effects, (such as notmuch_message_maildir_flags_to_tags implicitly calling notmuch_message_tags_to_maildir_flags and maybe even opening up some bad looping possibilities). Much better to stick with what we have documented, which we believe will actually be useful, (and easy enough to comprehend).

test: Add a new test that removal of a maildir flag also changes tags

2010-11-11T11:40:19Z

This test exposes an existing bug, so is currently failing.

test: Rework recently-added additional maildir-sync tests

2010-11-11T11:40:19Z

These needed to be changed to be brought up to the current state of the maildir-sync tests. This includes style changes, but also the elimination of any assumption about pre-existing message filenames, (such as msg-003) which actually don't exist anymore. Also, the known broken tests are changed to emit FAIL rather than BROKEN simply to make them easier to fix, (so that they print the current problems rather than hiding them). Finally, an additional test is added to ensure that when a duplicate file is added without flags, it doesn't invalidate flags from other duplicates, (instead the flags are effectively merged).

test: More maildir synchronization tests

2010-11-11T10:35:03Z

Add maildir synchronization tests for multiple messages with the same message-id. As this is not yet implemented in notmuch, some of these teste are marked as BROKEN. I use $(< ) operator to avoid fiddling with stripped trailing newlines from test results which happens when output+=$(command) is used.

test: Rework testing of maildir-synchronization feature.

2010-11-11T10:35:03Z

This change reworks these tests in several ways: 1. Bring tests into "new" test style preferring test_expect_equal over test_expect_success in almost all cases. 2. Don't emit test results for intermediate items not actually being tested, (things like "no new messages", "search for message", etc.). Those things are already covered by existing tests such as "basic" or "search" and only serve to obscure what's actually being tested. 3. Change sense of the test showing failure to rename a file from "new" to "cur" when "cur" doesn't exist. In this case, notmuch should detect that this is not a maildir and should not attempt to do any renaming of the file. 4. Extend dump/restore test to also exercise addition of tag, not just removal. Both items #3 and #4 above show shortcomings in the current implementation. These are currently resulting in test results of FAIL and indicate bugs that need to be fixed.

Tests for maildir synchronization

2010-11-10T21:09:32Z

Signed-off-by: Michal Sojka