notmuch/test/multipart, branch 0.6.1

test: modify multipart test to use test_expect_equal_file

2011-06-03T22:24:35Z

Again, this is a much cleaner and more thorough test, and in fact exposes a bug in the format=text output, that will be fixed the next commit. Because of this, some of the multipart tests currently fail.

test: Add test showing notmuch corrupts a part with a CRLF pair in it

2011-05-31T22:39:26Z

Since commit 2f8871df6ea3c0b44f85a0fc1b4f58a6b70b0a0e notmuch has been using a function (show_part_content) originally written only for text parts to save all MIME parts. The problem with this is that this function converts CRLF pairs to LF only and optionally converts to UTF-8 encoding. These two conversions have the potential to corrupt binary data when passed through the function. This test demonstrates that corruption, and so fails currently, until we fix the bug.

test: Fix a misspelling in one of our test cases.

2011-05-31T22:19:12Z

Not that it affects the correctness of the test, but it's nice to use proper spelling. This kind of change could invalidate a signature on the test message, but I think that would have happened previously when the HTML part was added in the first place.

tag signed/encrypted during notmuch new

2011-05-27T23:22:00Z

This patch adds the tag "signed" to messages with any multipart/signed parts, and the tag "encrypted" to messages with any multipart/encrypted parts. This only occurs when messages are indexed during notmuch new, so a database rebuild is required to have old messages tagged.

Update some more recent tests to use /usr/bin/env to find bash

2011-05-27T21:08:04Z

The recentl-applied patch had grown stale, so update the tests that had been created since it was originally written.

test: Expand multipart test to cover "notmuch reply" as well

2011-05-24T19:19:18Z

This gives coverage for the segmentation fault in "notmuch reply" that was just fixed with the previous commit.

test: Expand multipart test to cover part output in all formats.

2011-05-24T19:19:18Z

The example multipart message is made a bit more complicated by adding a message/rfc822 message, and the all parts are output and tested in all output formats.

test: remove hard-coded paths from multipart test

2011-05-20T18:32:47Z

Small oversite, easily corrected.

notmuch show: Properly nest MIME parts within mulipart parts

2011-05-17T22:58:57Z

Previously, notmuch show flattened all output, losing information about the nesting of the MIME hierarchy. Now, the output is properly nested, (both in the --format=text and --format=json output), so that clients can analyze the original MIME structure. Internally, this required splitting the final closing delimiter out of the various show_part functions and putting it into a new show_part_end function instead. Also, the show_part function now accepts a new "first" argument that is set not only for the first MIME part of a message, but also for each first MIME part within a series of multipart parts. This "first" argument controls the omission of a preceding comma when printing a part (for json). Many thanks to David Edmondson for originally identifying the lack of nesting in the json output and submitting an early implementation of this feature. Thanks as well to Jameson Graef Rollins for carefully shepherding David's patches through a remarkably long review process, patiently explaining them, and providing a cleaned up series that led to this final implementation. Jameson also provided the new emacs code here.

notmuch show: Include output for the enclosing multipart part of a MIME mail

2011-05-17T21:51:06Z

Previously, the outer multipart part of any multipart/mixed, multipart/signed, etc. MIME message was silently omitted from the "notmuch show" output. This prevented any client from correctly determining to which parts a signature applies, for example. Now, we actually emit these parts as their own parts. The output is still flattened---the contained parts are not yet included "within" the multipart part---so it's still not possible to determine to which parts a signature applies, but this is one step along the path. The test suite is updated to reflect this change, (though we'll eventually want to fix the emacs interface to not display buttons for the multipart enclosure parts as there's nothing useful for the user to actually do with them).