notmuch/test/reply, branch debian/0.17-5

test: Canonicalize RFC 2047 encoding and charset

2013-08-20T07:14:25Z

RFC 2047 states that the encoding and charset in an encoded word are case-insensitive, so force them to lower case in the reply test. This fixes an issue caused by GMime versions (somewhere between 2.6.10 and 2.6.16), which changed the capitalization of the encoding.

reply: Use RFC 2822/MIME wholly for text format template

2013-08-17T07:06:08Z

Previously, reply's default text format used an odd mix of RFC 2045 MIME encoding for the reply template's body and some made-up RFC 2822-like UTF-8 format for the headers. The intent was to present the headers to the user in a nice, un-encoded format, but this assumed that whatever ultimately sent the email would RFC 2047-encode the headers, while at the same time the body was already RFC 2045 encoded, so it assumed that whatever sent the email would *not* re-encode the body. This can be fixed by either producing a fully decoded UTF-8 reply template, or a fully encoded MIME-compliant RFC 2822 message. This patch does the latter because it is a) Well-defined by RFC 2822 and MIME (while any UTF-8 format would be ad hoc). b) Ready to be piped to sendmail. The point of the text format is to be minimal, so a user should be able to pop up the template in whatever editor they want, edit it, and push it to sendmail. c) Consistent with frontend capabilities. If a frontend has the smarts to RFC 2047 encode the headers before sending the mail, it probably has the smarts to RFC 2047 decode them before presenting the template to a user for editing. Also, as far as I know, nothing automated consumes the reply text format, so changing this should not cause serious problems. (And if anything does still consume this format, it probably gets these encoding issues wrong anyway.)

reply: Remove extraneous space from generated References

2013-08-17T07:05:44Z

Previously, the References header code seemed to assume notmuch_message_get_header would return NULL if the header was not present, but it actually returns "". As a result of this, it was inserting an unnecessary space when concatenating an empty or missing original references header with the new reference. This shows up in only two tests because the text reply format later passes the whole reply template through g_mime_filter_headers, which has the side effect of stripping out this extra space.

reply: Test replying to messages with RFC 2047-encoded headers

2013-08-17T07:04:07Z

test: add tests for notmuch reply From guessing

2012-05-25T00:56:35Z

Add tests for picking up user's From address from fallback headers Envelope-To, X-Original-To, and Delivered-To. Signed-off-by: Jani Nikula

test: whitespace-cleanup for most test/* files

2012-01-22T13:12:12Z

Used emacs (whitespace-cleanup) function to "cleanup blank problems" in test files where that could be done without breaking tests; test/emacs was partially, and test/multipart was fully reverted.

cli: pick the user's address in a group list as from address

2012-01-17T01:06:34Z

Messages received to a group list were not replied to using the from address in the list. Fix it. Signed-off-by: Jani Nikula

test: add known broken test for reply from address in named group list

2012-01-17T01:06:34Z

If a message was received to the user's address that was in a named group list, notmuch reply does not use that address for picking the from address. Groups lists are of the form: foo:bar@example.com,baz@example.com; Signed-off-by: Jani Nikula

test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability

2011-05-27T21:03:28Z

Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way systems running on bash < 4 can prepend bash >= 4 to path before running the tests.

test: Update tests with removal of bcc from reply

2010-10-28T00:34:31Z

Update the tests so that they no longer expect the Bcc header in the output of "notmuch reply" now that it has been removed. Edited-by Carl Worth: Simply applying the change to our newly modularized test suite.