notmuch/test/test-lib.sh, branch 0.33.1

test: add test_expect_equal_file_nonempty

2021-08-21T21:55:41Z

A common bug in tests is that the code used to generate the EXPECTED file fails, generating no output. When the code generating the OUTPUT file fails in the same way, the test passes, even though there is a failure being hidden. Add a new test function that guards against this.

test: factor out test_diff_file_

2021-08-21T21:55:27Z

A following commit will use this new function in a public test function.

test/expect_equal_file: whitespace cleanup

2021-08-21T21:51:04Z

No functional change, just reindent to Emacs defaults.

test: revert to mkdir -p to make results directory.

2021-08-03T23:35:13Z

As suggested by id:m21r7al3mt.fsf@guru.guru-group.fi

cli/show: produce "email" element in sigstatus

2021-06-26T16:07:47Z

When the certificate that signs a message is known to be valid, GMime is capable of reporting on the e-mail address embedded in the certificate. We pass this information along to the caller of "notmuch show", as often only the e-mail address of the certificate has actually been checked/verified. Furthermore, signature verification should probably at some point compare the e-mail address of the caller against the sender address of the message itself. Having to parse what gmime thinks is a "userid" to extract an e-mail address seems clunky and unnecessary if gmime already thinks it knows what the e-mail address is. See id:878s41ax6t.fsf@fifthhorseman.net for more motivation and discussion. Signed-off-by: Daniel Kahn Gillmor

Merge branch 'release'

2021-06-20T20:15:20Z

test: check openssl prequisite for add_gpgsm_home

2021-06-08T20:15:46Z

This is a fix for the test failures reported by Dan Čermák [1]. It is more robust to check for the prerequisite inside the function that uses it, rather than in every test file that calls the function. [1]: id:87k0n4fqgm.fsf@tethera.net

test: aggregate-results updates

2021-06-07T23:16:33Z

notmuch-test will now call aggregate-results.sh with file list that it compiles based on the test ran, and aggregate-results will report failure is any of the test files are missing. With this notmuch-test no longer has to exit in non-parallel run if some test fail to write its report file -- so it works as parallel tests in this sense. Changed test_done() in test-lib.sh write report file in one write(2), so there is (even) less chance it being partially written. Also, now it writes 'total' last and aggregate-results.sh expects this line to exist in all report files for reporting to be successful. Added 'set -eu' to notmuch-test and modified code to work with these settings. That makes it harder to get mistakes slipped into committed code.

test: say_color() in one write(2)

2021-05-23T11:05:15Z

say_color() used to call (builtin) printf (and tput(1) to stdout) several times, which caused attempts to write messages with color to have partial content (e.g. escape sequences) often intermixed with other tests when parallel tests were run. Now, with all output collected, then written out using one printf, all strings with color print out correctly ((at least short) write(2)'s appear to write out "atomically"). While at it, used only one tput(1) execution to determine whether color output works, and made bold/colors/sgr0 to tput(1) their values once per test.

test: ignore debugging messages

2021-05-23T11:03:02Z

Previously building with "-DDEBUG" broke the test suite in several places.