thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.15_rc1 2013-01-08T00:49:00Z 2013-01-08T00:49:00Z David Bremner bremner@debian.org 2012-12-25T19:42:47Z urn:sha1:bd829fde9640cf23482b3f1dfe2007ef38f2b24a This test also serves as documentation of the quoting requirements. The comment lines are so that it exactly matches the man page. Nothing more embarrassing than having an example in the man page fail. 2013-01-08T00:49:00Z David Bremner bremner@debian.org 2012-12-25T19:42:44Z urn:sha1:bbdbc838547667c880ee38d017f751ebe5da49ab The (now fixed) bug that this test revealed is that unquoted message-ids with whitespace or other control characters in them are split into several tokens by the Xapian query parser. 2013-01-08T00:49:00Z David Bremner bremner@debian.org 2012-12-25T19:42:43Z urn:sha1:9a31cbd3867b286fb7c26533d1d8589d49e879cc We test quotes seperately because they matter to the query escaper. 2013-01-08T00:49:00Z David Bremner bremner@debian.org 2012-12-25T19:42:42Z urn:sha1:e77a99f44e47951bb1a0bb2d8a5840f8cfabac3d This tests argument parsing, blank lines and comments, and basic hex decoding functionality. 2013-01-08T00:49:00Z David Bremner bremner@debian.org 2012-12-25T19:42:41Z urn:sha1:45c593095b9be9f28971c36aebf47520f7929bc4 This is based on the similar test for notmuch restore, but the parser in batch tagging mode is less tolerant of a few cases, in particular those tested by illegal_tag. 2013-01-07T02:47:35Z Austin Clements amdragon@MIT.EDU 2013-01-03T21:47:49Z urn:sha1:401dbebd4803477563eff03d719605ed37a8e44d We recently switched to popping up a buffer to report CLI errors, but this was too intrusive, especially for transient errors and especially since we made fewer things ignore errors. This patch changes this to display a basic error message in the minibuffer (using Emacs' usual error handling path) and, if there are additional details, to log these to a separate error buffer and reference the error buffer from the minibuffer message. This is more in line with how Emacs typically handles errors, but makes the details available to the user without flooding them with the details. Given this split, we pare down the basic message and make it more user-friendly, and also make the verbose message even more detailed (and more debugging-oriented). 2013-01-07T02:40:32Z Austin Clements amdragon@MIT.EDU 2013-01-06T20:22:41Z urn:sha1:425e2bc81263230df301c67d93c64ff9685ff840 This switches the new batch-tag format away from using a home-grown hex-encoding scheme for message IDs in the dump to simply using Xapian queries with Xapian quoting syntax. This has a variety of advantages beyond presenting a cleaner and more consistent interface. Foremost is that it will dramatically simplify the quoting for batch tagging, which shares the same input format. While the hex-encoding is no better or worse for the simple ID queries used by dump/restore, it becomes onerous for general-purpose queries used in batch tagging. It also better handles strange cases like "id:foo and bar", since this is no longer syntactically valid. 2013-01-07T02:40:01Z Austin Clements amdragon@MIT.EDU 2013-01-06T20:22:40Z urn:sha1:d08c714b6a172cf0018bee4f60aff069d5508d4e When we switch to using regular Xapian queries in the dump format, \n will cause problems, so we disallow it. Specially, while Xapian can quote and parse queries containing \n without difficultly, quoted queries containing \n still span multiple lines, which breaks the line-orientedness of the dump format. Strictly speaking, we could still round-trip these, but it would significantly complicate restore as well as scripts that deal with tag dumps. This complexity would come at absolutely no benefit: because of the RFC 2822 unfolding rules, no amount of standards negligence can produce a message with a message ID containing a line break (not even Outlook can do it!). Hence, we simply disallow it. 2013-01-06T14:04:19Z David Bremner bremner@debian.org 2012-12-26T19:36:33Z urn:sha1:d705a6a45bf691b60101203bd09a459be255dceb This patch corrects several undesirable behaviours: 1) Empty files were not detected, leading to buffer read overrun. 2) An initial blank line cause restore to silently abort 3) Initial comment line caused format detection to fail 2013-01-06T13:35:41Z David Bremner bremner@debian.org 2012-12-26T19:36:32Z urn:sha1:4dea9bb442f18081347708bc5446db505441fbba Three of these are marked broken; the third is a regression test, since it passes by virtue of batch-tag being the default input format.