notmuch/test, branch 0.26_rc1

cli/reply: make --decrypt take a keyword

2017-12-29T20:45:55Z

This brings the --decrypt argument to "notmuch reply" into line with the other --decrypt arguments (in "show", "new", "insert", and "reindex"). This patch is really just about bringing consistency to the user interface. We also use the recommended form in the emacs MUA when replying, and update test T350 to match.

cli/show: make --decrypt take a keyword.

2017-12-29T20:45:46Z

We also expand tab completion for it, update the emacs bindings, and update T350, T357, and T450 to match. Make use of the bool-to-keyword backward-compatibility feature.

cli: some keyword options can be supplied with no argument

2017-12-29T20:45:35Z

We might change some notmuch command line tools that used to be booleans into keyword arguments. In that case, there are some legacy tools that will expect to be able to do "notmuch foo --bar" instead of "notmuch foo --bar=baz". This patch makes it possible to support that older API, while providing a warning and an encouragement to upgrade.

python: add decrypt_policy argument to Database.index_file()

2017-12-24T13:47:35Z

We adopt a pythonic idiom here with an optional argument, rather than exposing the user to the C indexopts object directly. This now includes a simple test to ensure that the decrypt_policy argument works as expected.

test: final named query test works regardless of Xapian FieldProcessor

2017-12-21T13:35:20Z

This test passes with older versions of Xapian as well, because neither query returns any results. This should resolve the travis build failure at https://travis-ci.org/notmuch/notmuch/builds/318571658 Signed-off-by: Daniel Kahn Gillmor

lib: return "" rather than NULL from notmuch_thread_get_authors

2017-12-21T13:22:30Z

The current behaviour is at best under-documented. The modified test in T470-missing-headers.sh previously relied on printf doing the right thing with NULL, which seems icky. The use of talloc_strdup here is probably overkill, but it avoids having to enforce that thread->authors is never mutated outside _resolve_thread_authors_string.

test: retrying lock tests are broken when built against older Xapian

2017-12-19T11:14:13Z

If we're building against a version of Xapian that doesn't offer retrying the lock, we should be honest and describe the tests as broken, rather than marking them as missing a test prerequisite. missing test prerequisites should be for specific components of the test harness that are missing, not for the backend library notmuch uses.

test: named query tests are broken when missing Xapian FieldProcessor

2017-12-19T11:14:07Z

Named queries don't work without Xapian FieldProcessor. Rather than silently skipping them, we should explictly mark them as broken when building against an older version of Xapian.

test: searching by absolute date is broken without Xapian FieldProcessor

2017-12-19T11:14:03Z

Previously, the test suite had simply silently skipped the absolute date test if we're using an archaic version of Xapian. For correctness, we should instead mark the test as broken. This also changes from string to numeric comparison when checking NOMTUCH_HAVE_XAPIAN_FIELD_PROCESSOR for consistency with other tests.

test: Add test to unset config items with the python bindings

2017-12-19T10:42:50Z