notmuch/test, branch 0.32.2

test: check openssl prequisite for add_gpgsm_home

2021-06-08T20:15:46Z

This is a fix for the test failures reported by Dan Čermák [1]. It is more robust to check for the prerequisite inside the function that uses it, rather than in every test file that calls the function. [1]: id:87k0n4fqgm.fsf@tethera.net

lib/n_d_index_file: re-use thread-id of existing message

2021-05-22T12:08:02Z

This prevents the message document getting multiple thread-id terms when there are multiple files with the same message-id. This change shifts some thread ids, requiring adjustments to other tests.

test: add known broken test for duplicate thread-id terms

2021-05-22T12:02:58Z

According to my bijection, this bug has been present since commit 411675a6ce in 2017. It is not completely clear what harm it causes in regulary use, but it (at least) makes notmuch crash when compiled with -DDEBUG_DATABASE_SANITY.

lib/open: restore default database path of $HOME/mail

2021-05-15T11:40:05Z

Although this default worked for "notmuch config get", it didn't work most other places. Restore the previous functionality, with the wrinkle that XDG locations will shadow $HOME/mail if they exist. This fixes a bug reported by Jack Kamm in id:87eeefdc8b.fsf@gmail.com

emacs: restore tag-changes and query bindings for tag hooks

2021-05-15T11:34:28Z

notmuch-before-tag-hook and notmuch-after-tag-hook are supposed to have access to two dynamic variables, tag-changes and query, but these were lost with the switch to lexical binding in fc4cda07 (emacs: use lexical-bindings in all libraries, 2021-01-13). Add a variant of Emacs's dlet (not available until Emacs 28) and use it in notmuch-tag to expose tag-changes and query to the hooks.

test: add known broken tests for notuch-{before,after}-tag-hook

2021-05-15T11:31:00Z

These tests illustrate the bug reported in id:87v97ytd2s.fsf@fastmail.fm

lib/notmuch_database_reopen: reload some database metadata

2021-05-12T11:40:04Z

In some uses of reopen, new documents and threads maybe have been added, and e.g. compaction may have changed the uuid.

test: change database from within pre-new hook

2021-05-12T11:34:34Z

Due to the change in the config system, notmuch keeps a notmuch database open when it would not do so before. Consequently, it can miss changes to the database which are done from a hook (while notmuch holds the databse in read only mode). When notmuch itself writes to the database after that it uses wrong assumptions about the last used doc id etc. Demonstrate this by triggering an assertion. (This new test succeeds with notmuch 0.31.4.) Signed-off-by: Michael J Gruber Amended-by: db. Check for both messages

test: test explicit configuration of backup directory

2021-05-10T14:13:07Z

Including the relative path that was broken until a recent commit.

test: test relative paths for database.hook_dir

2021-05-10T14:13:07Z