thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.34.3 2022-01-08T20:29:41Z 2022-01-08T20:29:41Z David Bremner david@tethera.net 2022-01-08T14:03:16Z urn:sha1:9e7ea628e6bddbd7345d053a3daf14af74896cc2 If we return regular Message objects, python will try to destroy them, and the underlying notmuch object, causing e.g. the crash [1]. [1]: id:87sfu6utxg.fsf@tethera.net 2022-01-08T20:29:41Z David Bremner david@tethera.net 2022-01-08T14:03:15Z urn:sha1:d9a2b900b6525874b913276af91840983d81b3f1 This reproduces the bug reported at [1]. The second test hints at the solution, making reply return OwnedMessage objects. [1]: id:87sfu6utxg.fsf@tethera.net 2021-12-29T18:11:21Z David Bremner david@tethera.net 2021-12-25T21:22:56Z urn:sha1:25e0f5e59293ce961549201fdc74f81a3cc1675c It makes perfect sense for users to want to pre-create .notmuch, e.g. to install hooks, so we should handle the case of a .notmuch directory without an actual xapian database more gracefully. 2021-12-29T18:11:10Z David Bremner david@tethera.net 2021-12-25T21:22:55Z urn:sha1:e43bad4883cf8a0c1d58d50238da599f9e170307 `notmuch new' should go ahead and create the xapian database if it is missing, even in the case where the parent .notmuch (or equivalent) directory exists. 2021-12-04T12:42:31Z David Bremner david@tethera.net 2021-10-30T16:22:35Z urn:sha1:d7f95724132bf658fd151630185899737e2ed829 Since release 0.32, libnotmuch provides searching for database and configuration paths. This commit changes the python module notmuch2 to use those facilities. This fixes the bug reported in [1], along with a couple of the deprecation warnings in the python bindings. Database.default_path is deprecated, since it no longer faithfully reflects what libnotmuch is doing, and it is also no longer used in the bindings themselves. This commit choose the default of config=CONFIG.EMPTY (equivalent to passing "" to notmuch_database_open_with_config). This makes the change upward compatible API-wise (at least as far as the test suite verifies), but changing the default to CONFIG.SEARCH would probably be more convenient for bindings users. [1]: id:87h7d4wp6b.fsf@tethera.net 2021-12-04T12:36:41Z David Bremner david@tethera.net 2021-10-30T16:22:34Z urn:sha1:caafab01a4409fd2a1a5d31b3d05815bf587d8e0 This reproduces the bug(s) reported in id:87h7d4wp6b.fsf@tethera.net 2021-12-04T12:36:23Z David Bremner david@tethera.net 2021-10-30T16:22:33Z urn:sha1:5f077bef37462267258f95f7400596a157878b14 This will allow testing the new python bindings using test_python, in addition to the current invocation of pytest. 2021-12-04T00:52:11Z David Bremner david@tethera.net 2021-10-28T01:34:19Z urn:sha1:59aac9cef37a9937bdf2265078d063673111f80b If the user passed a path, and we opened it, then we consider that definitive definition of "database.path". This makes libnotmuch respond more gracefully to certain erroneous combinations of NOTMUCH_CONFIG settings and config file contents. 2021-12-04T00:49:36Z David Bremner david@tethera.net 2021-10-28T01:34:17Z urn:sha1:378415a55762ff0222e3de6a2e20a9823ce1d07e This is arguably user error: having configuration file with bad settings in it (and/or having a bad NOTMUCH_CONFIG environment variable). On the other hand returning a different path than was actually opened is definitely a bug. 2021-12-04T00:47:05Z David Bremner david@tethera.net 2021-12-04T00:47:05Z urn:sha1:59a778ae4bae182101c43f1acde08452a6542299 It makes the tests easier to understand if we always use export for environment variables.