notmuch/test, branch 0.6

emacs: Fix to unconditionally display subject changes in collapsed thread view

2011-07-01T12:56:34Z

The feature to show subject changes in the collapsed thread view was originally added (8ab433607) with an option (notmuch-show-always-show-subject) to display the subject for all messages, even when there was no change. The subsequent commit (4f04d273) changed the sense of the test (or to and) and the name of the controlling variable (notmuch-show-elide-same-subject). But this commit is broken in a few ways: 1. The original definition of notmuch-show-always-show-subject was left around But the variable isn't actually used in the code at all, so it just adds clutter and confusion to the customization interface. 2. The name and description of the controlling variable doesn't match the implementation The name suggests that setting the variable to t will cause repeated subjects to be elided, (suggesting that when it is nil all subjects will be shown). However, when the variable is nil, no subjects are shown. So a correct name for the variable in this sense would be notmuch-show-subject-changes. Showing subject changes is a useful feature, and should be on by default. (We don't want to bury generally useful features behind customizations that users have to find). Rather than fixing the name of the variable and changing its default value, here we remove the condition entirely, such that the feature is enabled unconditionally. So both the currently-used variable and the stale definition of the formerly-used are removed. Also, the one relevant test-suite result is updated, (showing the intial subject of a collapsed thread, and no subject display for later messages that do not change the subject). (cherry picked from commit 580de27177de5cd6c5cbc9cc3759ce320216dd5b)

test: Use increment_mtime rather than sleep

2011-06-30T00:58:39Z

The sleep was to force the directory's mtime to advance between the previous notmuch new and the subsequent rm;notmuch new. The current convention is to use the existing increment_mtime function for this purpose, (which avoids the test suite being slowed down by calls to sleep). Thanks to Austin Clements for noticing this undesired sleep. (cherry picked from commit 55a78d5dbd96b80939458d9d6cc8a536b1befa87)

test:Folder tags shouldn't match after removal of file in given folder

2011-06-30T00:58:19Z

Test for bug. Current stemming support for notmuch adds extra terms to the DB which aren't removed when the file renames are detected. When folder tags are added to a message, Xapian terms for both XFOLDER and ZXFOLDER are generated. When one of the filenames are renamed/removed, only the XFOLDER tags are removed, leaving it possible for a match on a folder: tag that was previously but is no longer a match in the maildir. (cherry picked from commit 86e0baeb6df5509393832488c0de3520a1a5bdcb)

test: remove useless test_emacs call from an emacs FCC test

2011-06-24T01:01:35Z

This was inadvertently left over when debugging an early version of this commit. -Carl Worth (cherry picked from commit 8bf0c1c3deb49d54e86c04826a05f0217a81cf47)

test: Test emacs message composing with various values for notmuch-fcc-dirs

2011-06-24T00:58:10Z

We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set). (cherry picked from commit 76b54f1898e97f6d07d0eaaf04a1772e60a7c48d)

tests: add a test for symbol hiding side effects

2011-06-23T10:05:25Z

The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e)

smtp-dummy: Prefer return rather than exit() in main.

2011-06-22T13:38:33Z

The main() function should be written as just another function with a return value. This allows for more reliable code reuse. Imagine that main() grows too large and needs to be factored into multiple functions. At that point, exit() is probably the wrong thing, yet can also be hard to notice as it's in less-frequently-tested exceptional cases.

Fix compilation warnings in test/smtp-dummy.c.

2011-06-22T13:38:33Z

* Remove unused variables in main(): buf, bytes and greeting. * Replace return with no value in main() with exit(3).

tests: Add optional use of timeout utility, if present.

2011-06-22T11:11:32Z

Each top level test (basic, corpus, etc...) is run with a fixed timeout of 2 minutes. The goal here is to treat a hung test as a failure. The emacs test for sending mail is known to be problematic on the Debian autobuilders. This is both a bandaid fix for that, and a sensible long term feature. (cherry picked from commit 5f99c80e02736c90495558d9b88008a768876b29)

test emacs: Add tests for hiding messages in notmuch-show view

2011-06-15T14:07:32Z

This test is expected to fail as it exposes a current bug, (which we hope to fix soon).