notmuch/test, branch debian/0.32.1-1

lib/open: restore default database path of $HOME/mail

2021-05-15T11:40:05Z

Although this default worked for "notmuch config get", it didn't work most other places. Restore the previous functionality, with the wrinkle that XDG locations will shadow $HOME/mail if they exist. This fixes a bug reported by Jack Kamm in id:87eeefdc8b.fsf@gmail.com

emacs: restore tag-changes and query bindings for tag hooks

2021-05-15T11:34:28Z

notmuch-before-tag-hook and notmuch-after-tag-hook are supposed to have access to two dynamic variables, tag-changes and query, but these were lost with the switch to lexical binding in fc4cda07 (emacs: use lexical-bindings in all libraries, 2021-01-13). Add a variant of Emacs's dlet (not available until Emacs 28) and use it in notmuch-tag to expose tag-changes and query to the hooks.

test: add known broken tests for notuch-{before,after}-tag-hook

2021-05-15T11:31:00Z

These tests illustrate the bug reported in id:87v97ytd2s.fsf@fastmail.fm

lib/notmuch_database_reopen: reload some database metadata

2021-05-12T11:40:04Z

In some uses of reopen, new documents and threads maybe have been added, and e.g. compaction may have changed the uuid.

test: change database from within pre-new hook

2021-05-12T11:34:34Z

Due to the change in the config system, notmuch keeps a notmuch database open when it would not do so before. Consequently, it can miss changes to the database which are done from a hook (while notmuch holds the databse in read only mode). When notmuch itself writes to the database after that it uses wrong assumptions about the last used doc id etc. Demonstrate this by triggering an assertion. (This new test succeeds with notmuch 0.31.4.) Signed-off-by: Michael J Gruber Amended-by: db. Check for both messages

test: test explicit configuration of backup directory

2021-05-10T14:13:07Z

Including the relative path that was broken until a recent commit.

test: test relative paths for database.hook_dir

2021-05-10T14:13:07Z

lib/config: expand relative paths when reading from database

2021-05-10T14:12:58Z

This makes the treatment of relative paths consistent between the database and config files.

test: add known broken test for relative setting of mail_root

2021-05-10T14:11:42Z

The behaviour should not change depending on where the configuration is stored.

lib/config: canonicalize paths relative to $HOME.

2021-05-10T14:08:18Z

Prior to 0.32, notmuch had the (undocumented) behaviour that it expanded a relative value of database.path with respect to $HOME. In 0.32 this was special cased for database.path but broken for database.mail_root, which causes problems for at least notmuch-new when database.path is set to a relative path. The change in T030-config.sh reflects a user visible, but hopefully harmless behaviour change; the expanded form of the paths will now be printed by notmuch config.