notmuch/test, branch debian/0.32.3-1thread-based email index, search, and tagginghttps://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.32.3-12021-08-18T00:09:56ZCLI/config: restore "notmuch config get built_with.*"2021-08-18T00:09:56ZDavid Bremnerdavid@tethera.net2021-07-18T17:58:22Zurn:sha1:686230712f3865ac0d0250084113d6d859cc2519
We need to special case the config section "built_with" because it is
not (currently) handled by the library. This seems consist with the
other sub-sub-commands 'list' and 'set'.
test/config: add tests for built_with2021-08-18T00:09:38ZDavid Bremnerdavid@tethera.net2021-07-18T17:58:21Zurn:sha1:202dde04e1057d0ab06a4e11f059f9ed2c6a717f
The "get" test is known broken because this functionality was dropped
during the 0.32 config rewrite.
lib/open: look in MAILDIR for database, as documented.2021-08-18T00:09:21ZDavid Bremnerdavid@tethera.net2021-08-04T10:42:35Zurn:sha1:d9300116909ea316c84fd6d3ee57c89074dcd260
This fixes the bug id:87bl9lx864.fsf@kisara.moe
test: add known broken tests for finding database via MAILDIR2021-08-18T00:07:53ZDavid Bremnerdavid@tethera.net2021-08-04T10:42:34Zurn:sha1:8376e814412f8165b781aa21dac654c2fc948306
This highlights a bug reported by several users, including
Mohsin Kaleem [1].
The inconsistent use of test_begin_subtest_known_broken is because
some of these tests pass even though the database cannot be
located. This problem is left for a future commit.
[1]: id:87bl9lx864.fsf@kisara.moe
test: check openssl prequisite for add_gpgsm_home2021-06-08T20:15:46ZDavid Bremnerdavid@tethera.net2021-06-08T19:39:10Zurn:sha1:a19d2b0d2b8c666d0a3641dc2e7e1b4e73b7c2bd
This is a fix for the test failures reported by Dan Čermák [1].
It is more robust to check for the prerequisite inside the function
that uses it, rather than in every test file that calls the function.
[1]: id:87k0n4fqgm.fsf@tethera.net
lib/n_d_index_file: re-use thread-id of existing message2021-05-22T12:08:02ZDavid Bremnerdavid@tethera.net2021-05-15T18:40:22Zurn:sha1:3f4de98e7c8c70f9a86a4f899147126f79907bd9
This prevents the message document getting multiple thread-id terms
when there are multiple files with the same message-id.
This change shifts some thread ids, requiring adjustments to other tests.
test: add known broken test for duplicate thread-id terms2021-05-22T12:02:58ZDavid Bremnerdavid@tethera.net2021-05-15T13:05:07Zurn:sha1:349fc2980346db2dba619cda5d9cdf0d943d3053
According to my bijection, this bug has been present since commit
411675a6ce in 2017. It is not completely clear what harm it causes in
regulary use, but it (at least) makes notmuch crash when compiled with
-DDEBUG_DATABASE_SANITY.
lib/open: restore default database path of $HOME/mail2021-05-15T11:40:05ZDavid Bremnerdavid@tethera.net2021-05-10T10:39:18Zurn:sha1:b3258244c84a7673db39c46cad96ddb63b131dae
Although this default worked for "notmuch config get", it didn't work
most other places. Restore the previous functionality, with the
wrinkle that XDG locations will shadow $HOME/mail if they exist.
This fixes a bug reported by Jack Kamm in id:87eeefdc8b.fsf@gmail.com
emacs: restore tag-changes and query bindings for tag hooks2021-05-15T11:34:28ZKyle Meyerkyle@kyleam.com2021-05-08T12:11:12Zurn:sha1:319dcfb50e5bc929719167afa353e19632ea55f3
notmuch-before-tag-hook and notmuch-after-tag-hook are supposed to
have access to two dynamic variables, tag-changes and query, but these
were lost with the switch to lexical binding in fc4cda07 (emacs: use
lexical-bindings in all libraries, 2021-01-13).
Add a variant of Emacs's dlet (not available until Emacs 28) and use
it in notmuch-tag to expose tag-changes and query to the hooks.
test: add known broken tests for notuch-{before,after}-tag-hook2021-05-15T11:31:00ZDavid Bremnerdavid@tethera.net2021-05-08T12:11:11Zurn:sha1:a663783343cb992d132ecc18e4e4d4e37bbf12e9
These tests illustrate the bug reported in id:87v97ytd2s.fsf@fastmail.fm