thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.34.1-1 2021-10-30T16:51:50Z 2021-10-30T16:51:50Z David Bremner david@tethera.net 2021-10-23T13:22:38Z urn:sha1:fe51c275fcd7107d92b40de511086300ba4060ed This fixes a potential memory leak, and makes the behaviour of notmuch_database_load_config (somewhat) consistent with n_d_{open,create} with config. 2021-10-30T16:49:37Z David Bremner david@tethera.net 2021-10-23T13:22:37Z urn:sha1:8f0b84789d4fda0182e073b68b73160c9b94a4b7 This is a bit different than n_d_{open,create}_with_config, since there are several non-zero status codes where we do want to return a non-NULL database structure. 2021-10-30T16:47:47Z David Bremner david@tethera.net 2021-10-23T13:22:36Z urn:sha1:2ba50b52302dce08068843e0029f9ee935a0d7f3 This code previously relied on _finish_open to free the notmuch struct on errors (except for the case of database == NULL, which was a potential double free). When we removed those frees from _finish_open, we introduced a (small) memory leak. In this commit, fix the memory leak, and harmonize the on-error behaviour with n_d_open_with_config. 2021-10-30T16:45:40Z David Bremner david@tethera.net 2021-10-23T13:22:35Z urn:sha1:f3fcdd2ddac2384c0c1daeffa495ad3ec01bc1af It seems sensible to harmonize the behaviour with n_d_open_with_config. In this commit we just assert the desired behaviour. 2021-10-30T16:43:58Z David Bremner david@tethera.net 2021-10-23T13:22:34Z urn:sha1:74c4ce6d88bcc643424c5d89cc8d30cd835e46c3 During refactoring for 0.32, the code that set notmuch=NULL on various errors was moved into _finish_open. This meant that the the code which relied on that to set *database to NULL on error was no longer correct. It also introduced a potential double free, since the notmuch struct was deallocated inside _finish_open (via n_d_destroy). In this commit we revert to "allocator frees", and leave any cleanup to the caller of _finish_open. This allows us to get back the behaviour of setting *database to NULL with a small change. Other callers of _finish_open will need free notmuch on errors. 2021-10-30T16:42:16Z David Bremner david@tethera.net 2021-10-23T13:22:33Z urn:sha1:a942cb8ee3f0e20d6cd72d25c432467a5ebfe93c The documentation claims that the database will be set to NULL in this case, but it is currently not happening. Based on a reproducer [1] from Austin Ray. [1]: id:20211021190401.imirxau2ewke6e2m@athena 2021-10-28T01:05:45Z David Bremner david@tethera.net 2021-10-27T13:20:40Z urn:sha1:e2b842afb1dff0621f30f50edb21a8e254b51f6e This is required when NOTMUCH_CONFIG has been unset, and is harmless otherwise. 2021-09-30T11:58:48Z David Bremner david@tethera.net 2021-09-30T11:58:48Z urn:sha1:3e2e724d53a1dce3ba00a20c71b2e6f735678136 notmuch 0.33.2 release 2021-09-29T23:04:31Z David Bremner david@tethera.net 2021-09-28T01:30:08Z urn:sha1:4760b4470c5d5782e52bd1a7761d9975a1db1fec As reported in id:87h7pxiek3.fsf@tethera.net, the previous version of the test is flaky. There is some so-far undebugged interaction between openssl and gpgsm that causes the keys to fail to import. As a potential workaround, use the key as exported by gpgsm, and eliminate openssl from this particular pipeline. 2021-09-11T14:11:29Z David Bremner david@tethera.net 2021-08-29T19:23:35Z urn:sha1:21e365f51a7ff17e5154cf06396aeafe3f7d9bd7 These work thanks to the previous wrapping of process creation primitives.