notmuch/test, branch debian/0.35-2 thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=debian%2F0.35-2 2022-01-27T11:48:27Z lib: strip trailing '/' from pathnames (sexp queries). 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:53Z urn:sha1:2c1d1107f5dacdb4a2c514909fd96f45f83e2f3c This changes makes the sexp query parser consistent with the infix one in ignoring trailing '/'. Here we do a bit better and ignore any number of trailing '/'. test: add multiple path, folder sexp query tests 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:52Z urn:sha1:8358841c66ee11110a784f2559e07477c067ba10 This is mainly to make sure we get trailing / removal correct. Also add regression test for path: in the infix parser matching the existing one for folder:. lib: drop trailing slash for path and folder searches (infix) 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:51Z urn:sha1:c62c22c9fb222d43d9b9956ce6b6e9985019ea2d This resolves an old bug reported by David Edmondson in 2014. The fix is only needed for the "boolean" case, as probabilistic / phrase searching already ignores punctuation. This fix is only for the infix (xapian provided) query parser. [1]: id:cunoasuolcv.fsf@gargravarr.hh.sledj.net test/sexp: tests for path, folder, including trailing '/' (sexp) 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:50Z urn:sha1:c73e273aaf7410c16a9597a041bd09f49352ced3 This duplicates the bug reported in [1], as well as adding some simple regression tests for 'path' and 'folder' searches which were previously missing for sexp syntax. [1]: id:cunoasuolcv.fsf@gargravarr.hh.sledj.net test: known broken tests for trailing / in path search (infix) 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:49Z urn:sha1:053a390370922a213b57f4f2e4bc2c5c8fb88c74 In [1], David Edmondson observed that the trailing / added by many completion mechanisms causes path searches to silently fail. This test reproduces that bug for both `path:' and `folder:' searches. [1]: id:cunoasuolcv.fsf@gargravarr.hh.sledj.net test: sanitize generated message files names 2022-01-27T11:48:27Z David Bremner david@tethera.net 2022-01-21T23:38:48Z urn:sha1:0756105832612ad12661d1dd61b7e7b5bfe99c6c It is fragile to encode the generated names into tests, as it makes tests break when e.g. new tests are added. There is a possibility that this will hide certain failures; in that case meaningful filenames should be chosen for the generated messages. lib/parse-sexp: handle lastmod queries. 2022-01-26T11:41:02Z David Bremner david@tethera.net 2022-01-20T13:36:05Z urn:sha1:0a32741fceb7778ced34064eacb7b5aac2c71638 This particular choice of converting strings to integers requires C++11. test/sexpr-search: add known broken tests for lastmod queries 2022-01-26T11:41:02Z David Bremner david@tethera.net 2022-01-20T13:36:04Z urn:sha1:341016c8ec34f838c2d72dc1bbfac567df054cd9 These are loosely modelled on the tests just above for date ranges, since the error conditions are similar. Some ideas also borrowed from T570-revision-tracking. lib/parse-sexp: support actual date queries. 2022-01-26T11:41:02Z David Bremner david@tethera.net 2022-01-20T13:36:03Z urn:sha1:77ab961a1dce3a31d1f0edf5c9bd83c295575835 The default argument processing overlaps somewhat with what is already done in _notmuch_date_strings_to_query, but we can give more specific error messages for the s-expression context. The extra generality of _sexp_parse_range will be useful when we implement additional range prefixes (at least 'lastmod' is needed). lib/parse-sexp: support zero argument date queries 2022-01-26T11:41:02Z David Bremner david@tethera.net 2022-01-20T13:36:01Z urn:sha1:303f207a54325158105aba400702637e670decda These are not too practical, although they may simplify some user query generation code. Mainly this adds a new prefix keyword to the parser.