notmuch/test, branch debian/0.38.3-5

Accept "key-missing" from a signature from a revoked key

2025-02-28T21:18:28Z

We have traditionally expected a signature to show up as "revoked" when the signing key is revoked. However, GnuPG's recent fix to avoid a denial of service against legitimate signatures appears to have changed the status of signature verification from keys which happen to have been revoked. See https://bugs.debian.org/1098995 and https://dev.gnupg.org/T7547 This change makes the test suite a little bit less brittle while we look for a resolution from upstream. It should probably also be backported to debian unstable unless a notmuch release to unstable is imminent. Signed-off-by: Daniel Kahn Gillmor (cherry picked from commit d330971b8bdb159e58a806e7ee24f3e5551d3f89)

test/emacs: add workaround for Emacs 30 pp changes

2025-02-25T20:51:00Z

This relies on the fact that setting pp-default-function has no effect for Emacs <30. (cherry picked from commit e3d4721b1ba4836c7646e057b50123fe994652eb)

lib: clear error message on success in _choose_database_path

2023-12-06T11:33:05Z

Previously we both found a database and returned a message saying that the database could not be found (along with a success code). This change should prevent spurious error output.

test: add known broken test for incorrect error message

2023-12-06T11:33:05Z

Duplicate bug reported in id:87wmtvcor5.fsf@alyssa.is The error message is nonsense, because notmuch config list actually includes the database in those two cases.

Pass error message from GLib ini parser to CLI

2023-09-23T11:34:48Z

The function _notmuch_config_load_from_file is only called in two places in open.cc. Update internal API to match the idiom in open.cc. Adding a newline is needed for consistency with other status strings. Based in part on a patch [1] from Eric Blake. [1]: id:20230906153402.101471-1-eblake@redhat.com

test: add known broken subtest for the bad config error message

2023-09-23T11:29:32Z

This is a bit fragile w.r.t. glib changing their error message, but it already helped me find one formatting bug, so for now I think it's worth it, instead of just grepping for "UTF-8".

CLI: exit with error when load_config returns an error.

2023-09-23T11:26:40Z

For now print a generic error message and exit with error on any non-success code. Previously the code exited, but with exit code zero, leading users / scripts to think the command had succeeded.

test: add known broken test for bad utf8 in config

2023-09-23T11:22:51Z

We should ideally print an informative error message, but at the very least we should not exit with success.

test: minimize impact of native compilation.

2023-08-26T10:45:36Z

Native compilation is kindof useless in the test suite because we throw away the cache after every subtest. The test suite could in principle share an eln cache within a given test file; for now try to minimize the amount of native-compilation. There is an intermittent bug where emacs loses track of its default-directory; I suspect (but have no proof) that bug is related to native compilation and/or race conditions. This patch seems to prevent that bug (or at least reduce its frequency).

test/setup: ignore blank lines in generated config

2023-08-21T22:30:54Z

The presense of the blank lines between sections depends on the version of glib. Strip them before comparison.