notmuch/test, branch debian/0.39-1

emacs/tree: call notmuch-hl-line-mode from tree-sentinel

2025-03-13T10:56:05Z

There is a a perceptible gap between when the tree shows up and when the hl-line is visible, but this is better than the previous state where the line did not show up at all until the user moved the cursor.

emacs/tree: condition hl-line-mode on notmuch-hl-line

2025-03-13T10:55:21Z

It isn't clear that this call to hl-line-mode will survive the coming re-organization to stop relying on hooks, but incrementally this at least makes the disabling behaviour consistent.

emacs: replace use of hook to draw hl-line in search mode

2025-03-13T10:48:53Z

In the thread at id:87fsfuuxwn.fsf@thinkbox, a bug is discussed where the point and hl-line overlay get out of sync, leading the user to open the wrong message. As far as I can tell this is caused by notmuch-hl-mode being invoked too early. This change bypasses the logic preventing notmuch-search-hook being called only once, so that the overlay is updated later after the buffer is full(er). This change may lead to the overlay being updated multiple times; if this is annoying we can add a similar buffer local variable to ensure it is only called once. The extra logic to check notmuch-search-target-line reduces the flicker somewhat by not highlighting the first line every time.

test/emacs: add tests for hl-line-mode integration

2025-03-13T10:18:07Z

Most of the known broken tests replicate (my intepretation of) the bug reported at id:87fsfuuxwn.fsf@thinkbox (or some unreported, but probably related bugs in tree/unthreaded view). The last 3 broken tests are just unimplimented planned functionality.

Accept "key-missing" from a signature from a revoked key

2025-02-28T20:32:36Z

We have traditionally expected a signature to show up as "revoked" when the signing key is revoked. However, GnuPG's recent fix to avoid a denial of service against legitimate signatures appears to have changed the status of signature verification from keys which happen to have been revoked. See https://bugs.debian.org/1098995 and https://dev.gnupg.org/T7547 This change makes the test suite a little bit less brittle while we look for a resolution from upstream. It should probably also be backported to debian unstable unless a notmuch release to unstable is imminent. Signed-off-by: Daniel Kahn Gillmor

test/emacs: add workaround for Emacs 30 pp changes

2025-02-25T11:25:59Z

This relies on the fact that setting pp-default-function has no effect for Emacs <30.

test/message-property: convert python tests from legacy bindings

2025-02-22T10:59:48Z

One test is deleted since that method is not provided by the new bindings. Similar things can be done by accessing the PropertiesMap returned by properties. This change is a prelude to removing the legacy bindings from the build.

test/count: convert library test from python to C

2025-02-22T10:59:48Z

The new python bindings do not support modifying query objects, so convert to C. There is a bit more boilerplate to handle errors but otherwise it is essentially a line by line translation.

test: drop tests for legacy python bindings

2025-02-22T10:59:48Z

This is a prelude to removing the legacy bindings from the build.

emacs/tree: sanitize subjects when drawing tree

2024-08-06T11:29:40Z

This fixes the bug reported in id:6F2EF901-8B4B-44FF-83C5-22F732BA95A6@gmail.com Unfortunately it turns out our test data has several tabs in the subject lines. The expected output was updated to reflect their removal and the ripple effect of several more subjects matching the previous ones.