notmuch/test, branch feature/git-remote

cli/git-remote: add check for missing messages

2025-08-11T12:52:10Z

In cases where a given 'export' both adds and deletes messages, we may not know what messages are actually missing until the end of processing. We thus do single pass of all remaining message-ids, and report any that are still missing at the end of the "export" operation.

cli/git-remote: handle message deletions

2025-08-11T12:52:10Z

There are two main possibilities. One is explicit delete ('D' command in the stream from git fast-export) and one is files disappearing between commits. It is less clear the latter can happen in well formed sequence of commits, but it could result e.g. from manual changes to the repo.

cli/git-remote: add export command

2025-08-11T12:52:10Z

Two (sub)features are stubbed out in this initial implementation: deleting messages (as opposed to tags), and missing messages. There are two corresponding tests marked as broken in T860-git-remote.sh. A third test passes with the stub, which is maybe not ideal, but at least it acts as a regression test.

cli/git-remote: add import command

2025-08-11T12:52:10Z

The output in default.import is based on a modified version of Felipe's git-remote-nm with Blake2 hashing replaced by SHA1 (for portability). This enable fetch/pull/clone, so test that as well.

cli: start remote helper for git.

2025-08-11T12:52:10Z

This is closely based on git-remote-nm (in ruby) by Felipe Contreras. Initially just implement the commands 'capabilites' and 'list'. This isn't enough to do anything useful so start some unit tests. Testing of URL passing will be done after clone (import command) support is added.

lib/config: add config keys for git-remote-notmuch.

2025-08-09T11:19:43Z

The precise function will be explained in a future update to notmuch-config(1).

lib: add notmuch_threads_status()

2025-08-04T13:43:35Z

While a number of errors can happen when iterating over threads (DatabaseModifiedError, memory allocation errors, etc.), the API currently cannot signal them to the caller, and either triggers an internal error (aborting the caller) or returns NULL from notmuch_threads_get() with no information on what actually went wrong. Add a new public function notmuch_threads_status() - similar to previously added notmuch_messages_status() - that allows propagating those errors to the caller. Use this to remove the INTERNAL_ERROR() in _notmuch_thread_create() (triggered by T642). Fixes: https://github.com/pazz/alot/issues/1460 Amended-By: db. Resolved whitespace disagreement between emacs and uncrustify in favour of uncrustify.

test: add a known broken test for DatabaseModifiedError from threads iteration

2025-08-04T13:17:53Z

This is similar to previously added T641, except here we iterate over threads rather than messages. After f375ea1add121c428f261473512831a169dfe335, the DatabaseModifiedError raised by Xapian is now handled in _notmuch_message_create(), resulting in a NULL message being returned to _notmuch_thread_create(), which currently triggers an internal error.

lib: handle DatabaseModifiedError in _notmuch_message_create

2025-07-24T10:30:58Z

If an open database is modified sufficiently by other callers, the open instance becomes invalid and operations on it throw DatabaseModifiedError. Per Xapian documentation, the caller is then supposed to reopen the database and restart the query. This exception is currently not handled in _notmuch_message_create(), leading to the default handler abort()ing the process. Catch this exception in _notmuch_message_create() and return an error instead of crashing. Since the entire query becomes invalid - including results that have already been read by the caller - this situation cannot be handled by libnotmuch transparently. A new public function - notmuch_messages_status() - is added to allow the callers to check whether the messages iterator was exhausted or terminated early due to a runtime error. This also allows memory allocation failure to be signalled to the caller. Amended-By: David Bremner [replace use of notmuch_messages_valid]

test: add another known broken test for uncaught DatabaseModifiedError

2025-07-06T12:14:49Z

This one is raised from _notmuch_message_create(). See also https://github.com/pazz/alot/issues/1460#issuecomment-2994101019