thread-based email index, search, and tagging https://git.notmuchmail.org/git/notmuch/atom?h=0.39 2021-03-13T12:45:34Z 2021-03-13T12:45:34Z uncrustify david@tethera.net 2021-03-13T12:45:34Z urn:sha1:0756d2587220898bdeec2067363a74629411093b This is the result of running $ uncrustify --replace --config ../devel/uncrustify.cfg *.c *.h in the util directory 2020-04-28T13:35:44Z David Bremner david@tethera.net 2020-04-27T12:24:22Z urn:sha1:ad9c2e91a012920bebfe70bc472d44678abc3259 It turns out that putting inline functions in C header files is not a good idea, and can cause linking problems if the compiler decides not to inline them. In principle this is solvable by using a "static inline" declaration, but this potentially makes a copy in every compilation unit. Since we don't actually care about the performance of this function, just use a non-inline function. 2020-04-16T10:55:23Z Olivier Taïbi oli@olitb.net 2020-04-14T17:38:40Z urn:sha1:b4f593e0e6288666e64d4f3d2651076f5eef1074 Context: I am compiling notmuch on OpenBSD which has a rather old zlib 1.2.3. It seems that the behaviour of gzgets() changed slightly between this version and more recent versions, but the manual does not reflect that change. Note that zlib's manual: - does not specify which error code (Z_OK or Z_STREAM_END) is set when EOF is reached, - does not indicate the meaning of Z_STREAM_END after gzgets(), but based on its meaning as a possible return value of inflate(), I would guess that it means EOF. amended by db: tidy commit message 2020-04-13T20:13:55Z David Bremner david@tethera.net 2020-04-12T23:00:31Z urn:sha1:2c1f783f5f4ad28d89f2e83d7253bae7bba98440 Although (as of 1.2.11) zlib checks this parameter before writing to it, the docs don't promise to keep doing so, so be safe. 2019-06-14T10:41:27Z uncrustify david@tethera.net 2019-06-13T10:33:13Z urn:sha1:1a8916786f9464af6c8a05713a4c987a6b097a12 This is the result of running $ uncrustify --replace --config ../devel/uncrustify.cfg *.c *.h in the util directory 2016-06-05T11:32:17Z Daniel Kahn Gillmor dkg@fifthhorseman.net 2016-06-02T16:26:14Z urn:sha1:6a833a6e83865f6999707cc30768d07e1351c2cb Many of the external links found in the notmuch source can be resolved using https instead of http. This changeset addresses as many as i could find, without touching the e-mail corpus or expected outputs found in tests. 2014-04-12T10:59:44Z David Bremner david@tethera.net 2014-03-29T17:53:17Z urn:sha1:85d9219a62c23c3ff58b42a63b65390526b89b6b The idea is to provide a more or less drop in replacement for readline to read from zlib/gzip streams. Take the opportunity to replace malloc with talloc.