summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>2019-02-09 12:34:37 -0500
committerDavid Bremner <david@tethera.net>2019-02-10 09:47:12 -0400
commit3c752b855f900f5251df9997514b4d27d9f38e83 (patch)
tree681070cfdaae2fa8b370f20338fa11766ef0009b
parent32fb3c420a408ccfd20301f0c527c4259bf721cc (diff)
emacs: Invoke gpg with --batch and --no-tty
When invoking gpg as a backgrounded tool, it's important to let gpg know that it is backgrounded, to avoid spurious prompts or other breakage. In particular, https://bugs.debian.org/913614 was a regression in GnuPG which causes problems when importing keys without a terminal, but gpg expects one. Ensuring that notmuch-emacs always invokes gpg as a background process should avoid some of these unnecessary failure. Thanks to Justus Winter for finding this problem. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
-rw-r--r--emacs/notmuch-crypto.el6
1 files changed, 3 insertions, 3 deletions
diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
index fc2b5301..353f721e 100644
--- a/emacs/notmuch-crypto.el
+++ b/emacs/notmuch-crypto.el
@@ -142,7 +142,7 @@ mode."
(with-selected-window window
(with-current-buffer buffer
(goto-char (point-max))
- (call-process epg-gpg-program nil t t "--list-keys" fingerprint))
+ (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--list-keys" fingerprint))
(recenter -1))))
(defun notmuch-crypto-sigstatus-error-callback (button)
@@ -153,9 +153,9 @@ mode."
(with-selected-window window
(with-current-buffer buffer
(goto-char (point-max))
- (call-process epg-gpg-program nil t t "--recv-keys" keyid)
+ (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--recv-keys" keyid)
(insert "\n")
- (call-process epg-gpg-program nil t t "--list-keys" keyid))
+ (call-process epg-gpg-program nil t t "--batch" "--no-tty" "--list-keys" keyid))
(recenter -1))
(notmuch-show-refresh-view)))