diff options
| author | Tim Quelch <tim@tquelch.com> | 2020-09-12 14:45:40 +1000 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2020-09-19 06:49:17 -0300 |
| commit | 45193bab16c728ba892a5d45fc62ef59e2a6ef85 (patch) | |
| tree | 1c3c6eab40024568f17a0daa628fb99173e602e9 | |
| parent | d127b16afe2e5c0f245400bc74d96208372075a2 (diff) | |
emacs: Remove notmuch-mua-message-send-hook
Currently `message-send-hook` functions are being called twice: In
notmuch send common when `notmuch-mua-send-hook` functions are
run (which by default includes `notmuch-mua-message-send-hook`) and in
`message-send` itself.
Because `message-send-hook` functions are run in `message-send` itself,
we don't need also need to run them before we delegate to `message-send`
Calling `notmuch-mua-message-send-hook` resulted in functions in
`message-send-hook` to be called twice. This causes bugs in
non-idempotent hook functions.
| -rw-r--r-- | emacs/notmuch-mua.el | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index dcddca76..03c7cc97 100644 --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -40,7 +40,7 @@ ;; -(defcustom notmuch-mua-send-hook '(notmuch-mua-message-send-hook) +(defcustom notmuch-mua-send-hook nil "Hook run before sending messages." :type 'hook :group 'notmuch-send @@ -601,11 +601,6 @@ unencrypted. Really send? ")))) (interactive) (message-kill-buffer)) -(defun notmuch-mua-message-send-hook () - "The default function used for `notmuch-mua-send-hook', this -simply runs the corresponding `message-mode' hook functions." - (run-hooks 'message-send-hook)) - ;; (define-mail-user-agent 'notmuch-user-agent |