aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-12-07Make author order tests more strict.Austin Clements
Use varying dates in the test messages to test the order authors are listed in. Add tests with repeated author names and unusual date ordering. Most of these are broken at the moment, but will be fixed shortly. Edited-by: Carl Worth <cworth@cworth.org>: Also update the expected results for existing emacs tests that currently codify the incorrect author ordering, (and similarly note them as broken in the current test suite).
2010-12-07Fix handling of broken tests.Austin Clements
Make sure to close the subtest for test_expect_equal_failure, just like in test_expect_equal.
2010-12-07emacs: Remove over-eager regular expressions from notmuch-wash-tidy-citations.David Edmondson
The removed expressions, which were used to ensure that citations were both preceded and followed by a blank line, were poorly implemented and caused a regexp stack overflow on messages more than a few thousand lines long.
2010-12-07emacs: Improve the display of truncated authors.David Edmondson
Incremental search does not match strings that span a visible/invisible boundary. This results in failure to correctly isearch for authors in `notmuch-search' mode if the name of the author is split between the visible and invisible components of the authors string. To avoid this, attempt to truncate the visible component of the authors string on a boundary between authors, such that the entirety of an author's name is either visible or invisible.
2010-12-07emacs: Use truenames for Fcc paths.David Edmondson
Appease the test suite by using the true name for the Fcc directory path, otherwise a value for `notmuch-database-path' which includes symbolic links causes test suite failures.
2010-12-07test: Ignore files created during test failures.David Edmondson
When a test fails, a tmp.<testname> file is left behind. These files are useful for the person debugging the test failure, but are never anything we want to commit. Edited-by: Carl Worth <cworth@cworth.org>: Changed from tmp.emacs to tmp.* and added explanation in the commit message.
2010-12-05notmuch new: Scan directory whenever fs mtime is not equal to db mtimeCarl Worth
Previously, we would only scan a directory if the filesystem modification time was strictly newer than the database modification time for the directory. This would cause a problem for systems with an unstable clock, (if a new mail was added to the filesystem, then the system clock rolled backward, "notmuch new" would not find the message until the clock caught up and the directory was modified again). Now, we always scan the directory if the modification time of the directory is not exactly the same between the filesystem and the database. This avoids the problem described above even with an unstable system clock.
2010-11-23Fix to index the "Re" term present in any subject.Carl Worth
This was a misfeature where notmuch had extra code that just threw away legitimate information. It was never indexing an initial "Re" term in a subject. But some users have legitimately wanted to search for this term. The original code was written this way merely for strict compatiblity with the indexing performed by sup, but we're not taking advantage of that now anyway.
2010-11-23notmuch search: Fix missing final newline in "notmuch search --output=tags"Carl Worth
As mentioned in the recent test commits, this also fixes the missing '[' and ']' characters in the --format=json variant of "notmuch search --output=tags" as well.
2010-11-23test: Add --format=json testing to the "notmuch search --format" tests.Carl Worth
This testing *does* capture the bug of missing '[' and ']' characters int "notmuch search --output=tags" case. This is another manifestation of the same bug causing the missing final newline (as mentioned in the previous commit).
2010-11-23test: Add simple tests for "notmuch search --output=<>"Carl Worth
This code simply wasn't being exercised by the test suite before, so this will be useful. Meanwhile, there's currently a bug in "notmuch search --output=tags" in that it doesn't print a final newline. But the current test suite isn't able to catch this bug since the $() construct of the shell doesn't preserve the distinction of whether the final newline is present or not.
2010-11-23TODO: Note missing keybindings for next/previous thread in emacs client.Carl Worth
Seems a fairly obvious shortcoming to have survived this long.
2010-11-16compatibility with emacs22James Vasile
Emacs22 lacks apply-partially and mouse-event-p, so define them if emacs version is less than 23. With this change, I was able to begin using notmuch in emacs22. The definitions of apply-partially and mouse-event-p are copied from the emacs 23 distribution, (which is distributed under the GPLv3+ just as notmuch).
2010-11-16TODO: Add several items recently mentioned on the mailing list.Carl Worth
Getting things listed here means that I can safely archive away those messages without worrying that the ideas will get lost.
2010-11-16test: Don't print a test result for preliminary test setupCarl Worth
This test script does some initial test setup (generating a few messages), which is all well and good, but we don't need to print that as a test result---particularly since the test result was effectively hard-coded to always pass.
2010-11-16test: Fix bugs detected thanks to the previous commitMichal Sojka
2010-11-16test: Detect unfinished subsetsMichal Sojka
When test_begin_subtest is not followed by corresponding test_expect_equal, the output of the rest of the test script is errornously suppressed. Add code to detect these bugs in test scripts.
2010-11-16test: Break on test script (or other) errorMichal Sojka
Break notmuch-test whenever a test script returns non-zero status. This happens either when some test from the script fails or when there is an error in the script. This is especially useful in the latter case since the error may not appear in the final aggregated results.
2010-11-16test: Add trailing newline to error messagesMichal Sojka
The newline was removed from say_color in commit 222926ab to allow printing test status in the beginning of the line. Error messages are never followed by other text so we add the newline to error function.
2010-11-16test: Better handling of stdout and stderrMichal Sojka
Git-style tests (test_expect_success etc.) suppress stdout and stderr unless -v is given. Notmuch-style tests (created by test_begin_subtest and test_expect_equal) do not have this behavior so implement it the same. Additionally, for both test styles, the test-lib.sh is changed so that the content of suppressed stdout and stderr is shown in case of failed test. Finally a test for this functionality is added to basic tests.
2010-11-16emacs: Use `view-mode' when examining raw messages.David Edmondson
Explained-by: Carl Worth: This gives convenient keybindings for navigating the file and for quitting from the buffer, (since, with a raw message file the user will generally want to just view the message, not edit it).
2010-11-16configure: Add explicit check for glib >= 2.14Carl Worth
For cases where GMime is present, but happy with glib 2.12, for example.
2010-11-16configure: Use pkg-config --exists rather than --modversionCarl Worth
With --modversion we were asking for output that we were just throwing away anyway. The --exists option does just what we want, (no output and communivating only via return value). Also, --exists allows for testing versions of the package as well.
2010-11-11lib: Fix missing initialization of status field.0.5Carl Worth
This could have been a problematic bug. Fortuinately "gcc -O2" warns about it.
2010-11-11lib: Add two missing static qualifiersCarl Worth
The debian packaging is nice enough to notice when we accidentally leak private symbols to the public interface.
2010-11-11debian: Update list of symbols for libnotmuchCarl Worth
This release adds three new functions to the library interface.
2010-11-11debian: Add changelog entry for 0.5Carl Worth
Just pulling things from NEWS as usual.
2010-11-11Increment notmuch version to 0.5Carl Worth
The big change here is the support for maildir-flag synchronization. But there are a number of other thigns as well---library support for multiple filenames, new ruby bindings, improvements to the vim interface, and a few tweaks to the emacs interface.
2010-11-11Increment library version to 1.3.0Carl Worth
For the addition of three functions: notmuch_message_get_filenames notmuch_message_tags_to_maildir_flags notmuch_message_maildir_flags_to_tags
2010-11-11NEWS: Add notes for 0.5 release.Carl Worth
Which is ready to go now.
2010-11-11config: Fix confusing of "tag" and "flag" oin documentation.Carl Worth
It has been very difficult to get all of these right. I would not be surprised if I've still missed some.
2010-11-11emacs: add stash thread-id function to notmuch-search modeJameson Rollins
This add a "stash-map" for search-mode, just like in show-mode, and adds one function, bound to "i" to stash the thread-id of the current selected thread. Couldn't think of the correct way to stash other thread info, so I didn't add any other stash functions for now.
2010-11-11emacs: mv notmuch-{show,common}-do-stashJameson Rollins
Here we move the notmuch-show/notmuch-show-do-stash function to notmuch-lib/notmuch-common-do-stash. Nothing in this function is notmuch-show mode specific, so this move will make it cleaner to be used by other modes (such as notmuch-search).
2010-11-11emacs: Improve the definition and use of `notmuch-fcc-dirs'.David Edmondson
Re-work the declaration and definition of `notmuch-fcc-dirs'. The variable now allows three types of values: - nil: no Fcc header is added, - a string: the value of `notmuch-fcc-dirs' is the name of the folder to use, - a list: the folder is chosen based on the From address of the current message using a list of regular expressions and corresponding folders: ((\"Sebastian@SSpaeth.de\" . \"privat\") (\"spaetz@sspaeth.de\" . \"OUTBOX.OSS\") (\".*\" . \"defaultinbox\")) If none of the regular expressions match the From address, no Fcc header will be added.
2010-11-11emacs: Use the header line to show the subject of the thread.David Edmondson
2010-11-11emacs: Simplify subjects more aggressively.David Edmondson
Remove 're: ' or 'Re: ' from anywhere within a subject line rather than just at the beginning. This is to accommodate threads where a mailing list sometimes inserts a subject prefix. For example, if a thread has the subjects: [Orgmode] org-indent, org-inlinetask: patches on github Re: [Orgmode] org-indent, org-inlinetask: patches on github [Orgmode] Re: org-indent, org-inlinetask: patches on github the last of these would not have been considered the same and would therefore have been shown.
2010-11-11emacs: Elide the display of repeated subjects in thread display mode.David Edmondson
Collapsed messages do not show a "Subject:" line if the subject is the same as that of the previous message.
2010-11-11test: Update emacs tests for fix to counting of signature lines.Carl Worth
The recent bug fix invalidated some expected test results. Fix them up.
2010-11-11emacs: Correctly count the number of lines in a signature.David Edmondson
2010-11-11Update of the spec file to the 0.4 release.Scott Henson
2010-11-11tags_to_maildir_flags: Fix to preserve existing, unsupported flagsCarl Worth
This is to prevent notmuch from destroying any information the user has encoded as flags in the maildir filename. Tests are also added to the test suite to verify the documented behavior.
2010-11-11notmuch_message_tags_to_maildir_flags: Do nothing outside of "new" and "cur"Carl Worth
Some people use notmuch with non-maildir files, (for example, email messages in MH format, or else cool things like using sluk[*] to suck down feeds into a format that notmuch can index). To better support uses like that, don't do any renaming for files that are not in a directory named either "new" or "cur". [*] https://github.com/krl/sluk/
2010-11-11lib: Be honest in the documentation of the maildir functionsCarl Worth
I had originally hoped for better semantics, such as doing nothing in non-maildir directories, and preserving unknown maildir flags that happen to be present. We could still do those things, of course, but for now, remove them from the documentation since the implementation does not do these things yet.
2010-11-11notmuch setup: Fix to add maildir group (with comment) to existing fileCarl Worth
The intent of "notmuch setup" is that it adds new, documented sections to configuration files that were created before such sections were defined. But to make this work, we have to explicitly set an option in the maildir group if it didn't exist previously.
2010-11-11test: Move corpus emails into maildir directory structureCarl Worth
Now that we have maildir synchronization turned on by default, it's advantageous to make all of the tests exercise it as much as possible.
2010-11-11test: Fix emacs FCC test to account for new maildir synchronizationCarl Worth
The FCC code saves a message in maildir format, and sets the S flag by default, so now, automatically, FCC messages will not show up as "unread", (which seems natural enough).
2010-11-11Enable maildir synchronization by default.Carl Worth
This is a useful feature that most people should want, so enable it by default, (still allowing customization to disable it of course).
2010-11-11notmuch config: Add more documentation for maildir.synchronize_flagsCarl Worth
Including details on which actual flags are synchronized with which tags.
2010-11-11notmuch setup: Don't prompt about maildir synchronizationCarl Worth
This synchronization is one of those features that should just happen automatically. We allow for customization in case someone *really* wants to turn it off, but we don't need to prompt for this interactively. People with special needs can find the configuration file on their own.
2010-11-11notmuch_message_tags_to_maildir_flags: Don't exit on failure to rename.Carl Worth
It is totally legitimate for a non-maildir directory to be named "new" (and not have a directory next to it named "cur"). To support this case at least, be silent about any rename failure.