| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Most people who write lots of lisp tend to only sparsely use empty
"separator" lines within forms. In lisp they feel unnecessary and
since most files stick to this convention we get a bit confused
when there are extra empty lines. It feels like the s-expressions
are falling into pieces.
All of this is especially true between a function's doc-string and
body because the doc-string is colored differently, which visually
already separates it quite sufficiently from the code that follows.
|
|
|
|
In notmuch-show buffer insert invisible U+200E LEFT-TO-RIGHT MARK
character at the beginning of message header paragraph if the From
header contains a right-to-left character. This ensures that the
header paragraph is always rendered in left-to-right mode.
See Emacs Lisp reference manual section "(elisp) Bidirectional
Display" for more info.
|
|
On some systems (notably, the one shipped with LibreSSL),
default fingerprint digest algorithm is SHA256.
On other systems, users can change default digest algorithm by changing
default_md in /etc/ssl/default_md.
Let's ask openssl to provide us specific algorithm to make the test
more deterministic.
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
|
|
Starting from xapian 1.3.5, xapian switched default backend to glass.
From 00cdfe10 (build: drop support for xapian versions less than 1.4,
2020-04-22), we only support xapian 1.4.0+. Effectively, we don't need
to check for default xapian backend anymore.
Further more, from 99a7aac8 (test: drop use of db_ending, 2020-07-29),
our test framework has become independence from default xapian.
Let's drop it.
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
|
|
On different distro, pytest is suffixed with different patterns.
On the other hand, `python3-pytest' could be invoked correctly,
via `python3 -m pytest', the latter is used by our tests, now.
Switch to `$python -m pytest` to fix address all incompatible naming.
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
|
|
The main criteria is that they don't crash. Working with a closed
database is a bonus.
|
|
Also mention error return in API docs
|
|
Exception is caught.
|
|
The mtime is cached, so closing the db is not a problem. Writing the
mtime throws an exception, which is caught.
|
|
Falling out of the catch meant the error return was lost
|
|
There is a return value bug in notmuch_directory_delete that is hiding
the exception.
|
|
Also clarify API in error case.
|
|
This is a clone of the one for get_child_directories
|
|
Also clarify API in error case.
|
|
Start a new test file (for the notmuch_directory_* API group) to hold
this test.
|
|
Closing the database after the iterator is created is not a problem.
|
|
This allows finer control over when to close the database.
|
|
Also test n_messages_destroy.
|
|
This is a rare and probably serious programming error, so better not
to silently return a default value.
|
|
Use a URL https://notmuchmail.org/doc/latest to leave room for a
future more ambitious scheme deploying multiple versions.
This also forces the html docs to built as part of the release
process. In the future this should be updated to tolerate generating a
release without sphinx installed. This needs a new target analogous to
build-info and build-man that does nothing if sphinx is not installed.
|
|
This will allow the dropping of the test for the default ending from
configure.
|
|
Inspired by the suggestion of
id:20200727154108.16269-3-congdanhqx@gmail.com
to drop the configuration test for the default backend. This version
is hopefully robust against backend changes.
|
|
Check for (non)-crash.
|
|
Code is taken from the API docs, with the twist that the underlying
database is closed. Not crashing is the main point.
|
|
These are strictly to watch for crashes, so don't be too fussy about
the actual timestamps.
|
|
This is returning explicitely cached data, so no database access is needed.
|
|
This is similar to the case of toplevel messages. Currently everything
is cached, so no database access is necessary. This might change in
the future, but it should not crash in either case.
|
|
Include a test for the previously omitted non-trivial code path for
notmuch_thread_get_replies.
|
|
This is returning cached info, so does not need to access the (closed)
database.
|
|
This is just cached data, so as long as we don't prematurely free
anything, it should be fine.
|
|
As with other void API entries, not crashing counts as success.
|
|
At least these exceptions are caught.
|
|
Exception handling matches notmuch_query_search_threads, at least for
this case.
|
|
At least this exception is caught.
|
|
This relies on the change to not tear down the auxilary Xapian
objects, in particular the query parser, when the database is closed.
|
|
We just want to make sure accessing the query owned by a closed db
does not cause a crash.
|
|
|
|
Current functionality is too trivial to really justify a test, but
it's simpler just to test the complete API.
|
|
Start a new file of tests, to keep to the (emerging) scheme of one
notmuch_foo group per file
|
|
This is for consistency with the recently added tests for
notmuch_database_*.
|
|
static_cast is a bit tricky to understand and error prone, so add a
second pointer to (potentially the same) Xapian database object that
we know has the right subclass.
|
|
The plan is to change the underlying representation.
|
|
I'm not sure what the point of modifying that right before destroying
the object is. In a future commit I want to remove that element of the
object, so simplify that task.
|
|
Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to
signing as the sender using 'mml-secure-openpgp-sign-with-sender'.
|
|
The goal of this abstraction was to save space. But that failed as
the result actually was that four trivial lines got replace with 15
fairly complicated lines. The opposite of what it was supposed to
do.
Also it made it harder to come up with the fix in the previous commit;
simply grepping for the relevant symbols did not work because they get
constructed at run-time instead of appearing in the source file.
|
|
Starting with Emacs 27 undeclared variables in evaluated interactive
code uses lexical scope. This includes code passed with '--eval' as
we do in the Emacs tests, which also happen to assume dynamic scope.
- This can affect variables defined by libraries that we use. We
let-bind such variables to change the behavior of functions which we
then call with these bindings in effect. If these libraries are not
loaded beforehand, then the bindings are lexical and fail to have
the effect we intended.
At this time only 'smtpmail' has to be loaded explicitly (for the
variables let-bound in emacs_deliver_message and emacs_fcc_message).
'message' doesn't have to be loaded explicitly, because loading
'notmuch' (in 'run_emacs') already takes care of that, indirectly.
- Our own testing-only variables also have to be declared explicitly.
We should have done that anyway, but because of how and where these
variables are used it was very easy to overlook that (i.e. it isn't
something the byte-compiler ever looks at). Not so in Emacs 27
anymore; here this oversight caused four tests to fail.
The numeric values of these variables get incremented by functions
that we add to hooks that are run by many tests, not just the tests
where we actually inspect the value and therefore take care to let-
bind the values to 0 before we begin. The global values therefore
have to be numeric values as well. I have chosen -100 instead of 0
as the default in case someone writes a test that inspects the value
but forgets to let-bind the value. I hope that the unusual negative
value that one is going to see in such a case will help debugging
the issue.
|
|
|
