| Age | Commit message (Collapse) | Author |
|---|
|
QUERY_STRING was only used in two places, both to test whether a
variable should be stored in (or retrieved from) the database.
Since other configuration variables might be stored in the database in
the future, consolidate that test into a single function.
We also document that these configuration options should not be placed
in the config file.
|
|
If we see index options that ask us to decrypt when indexing a
message, and we encounter an encrypted part, we'll try to descend into
it.
If we can decrypt, we add the property index.decryption=success.
If we can't decrypt (or recognize the encrypted type of mail), we add
the property index.decryption=failure.
Note that a single message may have both values of the
"index.decryption" property: "success" and "failure". For example,
consider a message that includes multiple layers of encryption. If we
manage to decrypt the outer layer ("index.decryption=success"), but
fail on the inner layer ("index.decryption=failure").
Because of the property name, this will be automatically cleared (and
possibly re-set) during re-indexing. This means it will subsequently
correspond to the actual semantics of the stored index.
|
|
This allows us to create new properties that will be automatically set
during indexing, and cleared during re-indexing, just by choice of
property name.
|
|
We will want a user-facing place to record details about the use of
notmuch properties shortly. This establishes a new manual page for
that purpose.
|
|
This is currently mostly a wrapper around _notmuch_crypto_t that keeps
its internals private and doesn't expose any of the GMime API.
However, non-crypto indexing options might also be added later
(e.g. filters or other transformations).
|
|
It should now work without.
|
|
Make a distinction between source and build directories.
|
|
The primary motivation here is to fix TMP_DIRECTORY cleanup prior to
running each test when the current working directory is not the test
subdirectory. Tests with failures would leave their TMP_DIRECTORY
directory behind for debugging, and repeated out-of-tree test runs
would have old temp directories. (This lead to e.g. T310-emacs.sh
hanging because emacs would prompt for overwriting files.)
We remove the likely anyway defunct --root test option while at it,
just to be on the safe side when doing 'rm -rf' on the TMP_DIRECTORY.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
$TMP_DIRECTORY is a full path, while $test is not.
|
|
Make a distinction between source and build directories.
The expectation is that anyone sourcing test-lib-common.sh has sourced
export-dirs.sh.
|
|
Make a distinction between source and build directories.
|
|
Make a distinction between source and build directories.
|
|
Expect the tests to be run somewhere in the build directory
hierarchy. Allow for source and build directories to be passed through
the environment.
|
|
Move notmuch executable check into common code. Redundant for
notmuch-test runs, but works also for individual tests.
|
|
Don't assume the tests are always run from within the source tree.
|
|
Don't assume the tests are always run from within the source tree.
|
|
Don't assume the tests are always run from within the source tree.
|
|
Turns out round trip tests didn't really round trip anything. Broken
by yours truly in 971cdc72cdb8 ("test: make it possible to have
multiple corpora"). Ooops.
|
|
Subsequent patches will introduce a convention that properties whose
name starts with "index." will be stripped (and possibly re-added)
during re-indexing. This patch lays the groundwork for doing that.
|
|
If we're going to reuse the crypto code across both the library and
the client, then it needs to report error states properly and not
write to stderr.
|
|
This prepares us for using the crypto object in both libnotmuch and
the client.
|
|
This will make future diffs cleaner, make it easier to keep them
alphabetical, and make it easier to scan and search the documentation
sources.
|
|
|
|
Commit 0f314c0c99be ("cli: convert notmuch_bool_t to stdbool")
over-eagerly converted EXCLUDE_TRUE and EXCLUDE_FALSE to EXCLUDE_true
and EXCLUDE_false in notmuch-count.c. We could just fix the case back,
but convert the option to an actual boolean argument instead.
We've used a keyword argument rather than a boolean argument for
notmuch count --exclude for five years, since commit 785c1e497f05
("cli: move count to the new --exclude=(true|false|flag) naming
scheme."), "to allow future options to be added more easily". I think
we can conclude future options aren't coming any time soon.
|
|
In practice, we're going to see this function invoked differently
depending on which gmime we build against. The compatibility layer
forces our code into the lowest-common-denominator -- unable to make
use of new features even when built against a newer version.
Dropping the compatibility layer paves the way for clearer use of
features from GMime 3.0 in future commits.
|
|
Move add_gnupg_home to test-lib.sh to prepare it for reuse.
|
|
"typedef GMimeAddressType GMimeRecipientType" is already present
further down in the compatibility wrapper (with other typedefs). We
don't need it twice.
|
|
There's no chance that _notmuch_crypto_cleanup() will ever return
anything other than 0, and no one ever checks its return value anyway.
So make it return void instead of int.
|
|
notmuch_crypto_context_t was introduced (i think) as some sort of
abstraction layer to make notmuch somewhat independent of GMime. But
it isn't even useful for GMime 3.0 or later -- we can drop the
pretense that it's some sort of abstraction in this case, and just
call it what it is, GMimeCryptoContext, which is useful for building
against older versions of GMime.
This also renames _notmuch_crypto_get_context() to
_notmuch_crypto_get_gmime_context().
|
|
The notmuch_crypto_t struct isn't used externally, and we have no
plans to explicitly export it. Prefix its name (and associated
functions) with _ to make that intent clear.
|
|
C99 stdbool turned 18 this year. There really is no reason to use our
own, except in the library interface for backward
compatibility. Convert the lib internally to stdbool.
|
|
C99 stdbool turned 18 this year. There really is no reason to use our
own, except in the library interface for backward
compatibility. Convert the cli and test binaries to stdbool.
|
|
Renamed from out-of-tree-build-check.sh to be consistent with
other files in this directory.
Fixed quoting in "$srcdir" usage for additional robustness, other
quoting changes for consistency.
|
|
Reducing indent makes future changes easier. No functional changes.
|
|
Using a for loop makes it easier to use continue, in preparation for
future changes. No functional changes.
|
|
Clean up the control flow to prepare for future changes. No functional
changes.
|
|
Pedantically correct, although they're the same underlying type.
|
|
Pedantically correct, although they're the same underlying type.
|
|
The --entire-thread default depends on other arguments, so we'll have
to figure out if it was explicitly set by the user or not. The arg
parser .present feature helps us clean up the code here.
|
