aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-06-23fix sum moar typos [build scripts, Makefiles]Pieter Praet
Various typo fixes in comments within the Makefile and other build scripts. Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just build files.
2011-06-23start new changelog stanzaDavid Bremner
2011-06-23fix sum moar typos [text files]Pieter Praet
Various typo fixes in auxiliary text files included with the source, (README, TODO, etc.). Signed-off-by: Pieter Praet <pieter@praet.org> Edited-by: Carl Worth <cworth@cworth.org> Restricted to just text files.
2011-06-23Revert "debian: Override RPATH_LDFLAGS"David Bremner
This reverts commit fc126d89b2baa479d98c864fbef4174b6da707c0. This override of the make variable RPATH_LDFLAGS should no longer be required since the auto-configuration was fixed
2011-06-23Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup'Dmitry Kurochkin
This error occurs when `notmuch-fcc-dirs' is set to a list. The error was in the `notmuch-fcc-dirs' format check which was changed in an incompatible way from 0.4 to 0.5. The fix was extracted from a bigger patch series by David Edmondson id:"1290682750-30283-2-git-send-email-dme@dme.org". Signed-off-by: Jameson Graef Rollins <jrollins@finestructure.net>
2011-06-23test: Test emacs message composing with various values for notmuch-fcc-dirsCarl Worth
We exercise each of the documented values (nil, a string, and a list). For the list, we test matching a specific entry, matching a catch-all regular expression, and no match at all (in which case there is no FCC set).
2011-06-23debian: Set conflicts from package split to point to an existing version.David Bremner
The previous version was harmless, since there were no versions uploaded between ~237 and ~254, but this is less confusing.
2011-06-23debian: fix typo in short description of notmuch-vimDavid Bremner
Thanks to Dirk Eddelbuettel for noticing.
2011-06-23debian: update changelog for upload 0.6~254, bump standards version to 3.9.2debian/0.6_254David Bremner
2011-06-23debian: remove Xapian exceptions symbols from libnotmuch1.symbolsDavid Bremner
These were never intended to be public, since the library exports only a C API.
2011-06-23debian: split off vim interface to its own packageDavid Bremner
So far the package does notthing fancy with vim-addon-manager.
2011-06-23debian: split off emacs interface into its own package.David Bremner
- rename emacsen-install/remove files, and change embedded package name - split notmuch.install, notmuch.dirs - add Breaks/Replaces for previous notmuch packages with overlapping files.
2011-06-23debian: Build depend on emacs-nox instead of emacs.David Bremner
Nothing in the build process needs X, and the number of dependencies that need to be installed is much smaller.
2011-06-23debian: build package for python-bindings.David Bremner
This uses dh_python2 (included with sufficiently recent versions of the python/python-all packages). python-all brings in all of the supported versions of python. The double calls to dh_auto_install and friends are to avoid looping over python versions ourselves.
2011-06-23tests: add a test for symbol hiding side effectsDavid Bremner
The worry here is that a binary linking with libnotmuch might lose access to Xapian::Error symbols because libnotmuch hides them. We are careful here to create ./fakedb/.notmuch in order to trigger a Xapian exception, and not just a missing file check. Thanks to jrollins and amddragon for suggestions. (cherry picked from commit 66f37f5f6864a988f94ddb893e3a176af57f6c8e)
2011-06-23libnotmuch: add linker script to declare only notmuch_* symbols as global.David Bremner
This is closely tied to gcc and particularly gnu ld, but I guess the shared library linking code would need to be adjusted to work on a non-gnu linker anyay. I had to make a few not-obviously related changes to the lib/Makefile.local to make this work: libnotmuch_modules is defined with := and used in place of $^ (cherry picked from commit 014bf85b1c06ff49be2bde5a26433d2cf376cf70)
2011-06-22debian: add changlog stanza for new snapshot 0.6~237David Bremner
(cherry picked from commit 17daa480e435ad4c1d8f4f18447eff1ff36dbe00)
2011-06-22debian: Changelog stanza for new git snapshot 0.6~215David Bremner
(cherry picked from commit b85a415a7bd91c360c0acd453ead39be854f63f7)
2011-06-22debian: update symbols file for libnotmuch1David Bremner
One of the Xapian exception symbols has gone missing. Hopefully this doesn't mean we should be bumping the SONAME. (cherry picked from commit e8260d63f1f5a37094801ecd5d110bf48f22ee45)
2011-06-22debian: Changelog stanza for new snapshot 0.6~180David Bremner
(cherry picked from commit 54a3983d3c38830e2b609be0a96c5cf6dc6de054)
2011-06-22debian: update symbols file for libnotmuch1David Bremner
This re-exports three symbols from Xapian. (cherry picked from commit f36c36ddd13486d1e38b4dd0efa717108f56c4f9)
2011-06-22debian: Override RPATH_LDFLAGSDavid Bremner
Probably there is a nicer way to do this; perhaps it should be a configure option. (cherry picked from commit 387dc520dd68cc805e390f3a1399f85b5d5bd83a)
2011-06-22debian: Add changelog stanza for new snapshot 0.6~171David Bremner
After some debate, we settled on 0.6~$num as a snapshot version number, at least until 0.6 is released. This has the needed property of sorting after 0.5+nmu$num. (cherry picked from commit 54f7766febc3fa3c9dc475f6ec6718c5e87a189e)
2011-06-22debian: Add myself (David Bremner) as an uploaderDavid Bremner
This avoids having to mark every upload as a non-maintainer upload. (cherry picked from commit e849851d2d38cbf985f3fd884226100b93f3044f)
2011-06-22debian: Incorporate changelog entries from post 0.5 uploadsDavid Bremner
These uploads added the timeout to the tests to fix build failures. (cherry picked from commit 0901faabd90a689728d8079b3163bd76b29d29aa)
2011-06-22emacs: Show all multipart/alternative parts by default.Jameson Graef Rollins
This is patch is a temporary work-around for a slight regression that popped up in the part handling reorganization. Currently, text/plain parts are always preferred, if present, over other non-text/plain parts in multipart/alternative. However, this means that if there is a blank text/plain part, no content will be displayed. One way to get around this is to set the "notmuch-show-all-multipart/alternative-parts" customization variable to True ('t'), which will cause all parts to always be displayed. Since we want to move forward with the next release, we're going to set this variable true by default, to make sure that no content is unretrievably hidden from the user. Once we come up with a better solution for easy display of hidden parts we can set this back to a default value of 'nil'.
2011-06-22smtp-dummy: Prefer return rather than exit() in main.Carl Worth
The main() function should be written as just another function with a return value. This allows for more reliable code reuse. Imagine that main() grows too large and needs to be factored into multiple functions. At that point, exit() is probably the wrong thing, yet can also be hard to notice as it's in less-frequently-tested exceptional cases.
2011-06-22Fix compilation warnings in test/smtp-dummy.c.Dmitry Kurochkin
* Remove unused variables in main(): buf, bytes and greeting. * Replace return with no value in main() with exit(3).
2011-06-22debian: Generate version from debian/changelogDavid Bremner
This avoids patching the version file once per Debian upload. Original version file is saved and restored. (cherry picked from commit 2938a98bf4c4abe0426caee4555d889d655bc0df)
2011-06-22tests: Add optional use of timeout utility, if present.David Bremner
Each top level test (basic, corpus, etc...) is run with a fixed timeout of 2 minutes. The goal here is to treat a hung test as a failure. The emacs test for sending mail is known to be problematic on the Debian autobuilders. This is both a bandaid fix for that, and a sensible long term feature. (cherry picked from commit 5f99c80e02736c90495558d9b88008a768876b29)
2011-06-20Do not import notmuch in setup.py.David Bremner
Importing notmuch loads the notmuch shared library. When building without a system install of notmuch, this requires e.g. setting LD_LIBRARY_PATH for building and fails completely for cleaning.
2011-06-16Simplify (& fix) Message().__str__()Sebastian Spaeth
We were still using len(self.get_replies()) for the __str__ summary of a mail, but 1) len(Messages()) has just gone away 2) the number of replies can not be retrieved when we got the message via search_messages() anyway, and 3) it is likely quite expensive to pull all replies for all messages that we display a summary of. So we fix this by simplifying str(Message()) to omit the number of replies. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-16python: Bulletproof Database() path parameterSebastian Spaeth
libnotmuch (and python) crashed when I accidently passed in an invalid value as path argument to the Database() instantiation. Therefore, we now check via assert that the handed in path is actually a real string (or None). Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-16python: Improve API documentationSebastian Spaeth
Various API doc cleanups and improvements. No code change. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-16Implement Message.tags_to_maildir_flagsSebastian Spaeth
and also maildir_flags_to_tags. The methods will be invoked by db.add_message() and also (if not overridden via function parameter) by add|remove_tag and remove_all_tags. Documentation on the usage has been updated. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-15python: Improve documentationSebastian Spaeth
Improve the documentation with regard to the new __cmp__ and __hash__ methods and the implications of doing set arithmetic with Messages() objects. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-15Fix indentation in guess_from_received_header().Dmitry Kurochkin
2011-06-15Fix memory leak in guess_from_received_header().Dmitry Kurochkin
Mta variable was not free()d in one case.
2011-06-15Fix double free in guess_from_received_header().Dmitry Kurochkin
Before the change, the last loop in guess_from_received_header() did not reset domain and tld variables to NULL. This leads to double free error in some cases and possibly other bugs.
2011-06-15Simplify message and headers visibility code in notmuch-show view.Dmitry Kurochkin
Before the change, headers and message visibility functions took extra care to correctly set `buffer-invisibility-spec'. This was needed because headers overlay `invisible' property had only headers' invisibility spec. So visibility of headers was determined only by the headers invisibility spec. The patch sets headers overlay `invisible' property a list with both the headers and the message invisibility spec. This makes headers invisible if either of them is added to the `buffer-invisibility-spec' and allows to simplify the code.
2011-06-15Set higher priority for headers and hidden citation overlays.Dmitry Kurochkin
Before the patch, message, headers and hidden citation overlays had zero priority. All these overlay have `invisible' property. Emacs documentation says that we should not make assumptions about which overlay will prevail when they have the same priority [1]. It happens to work as we need, but we should not rely on undocumented behavior. [1] http://www.gnu.org/s/emacs/manual/html_node/elisp/Overlay-Properties.html
2011-06-15Fix hiding a message while some citations are shown in notmuch-show view.Dmitry Kurochkin
Before the change, message and citation invisibility overlays conflicted: if some citation is made visible and then the whole message is hidden, that citation remained visible. This happened because the citation's overlay has an invisible property which takes priority over the message overlay. The message invisibility spec does not affect citation visibility, it is determined solely by the citation overlay invisibility spec. Hence, if citation is made visible, it is not hidden by message invisibility spec. The patch changes citation overlay invisibility property to be a list which contains both the citation and the message invisibility specs. This makes the citation invisible if either of them is added to the `buffer-invisibility-spec'. Note that all citation visibility states are "restored" when the message hidden and shown again.
2011-06-15Set message invisibility spec properties before inserting the body.Dmitry Kurochkin
This would allow body-inserting code (in particular, wash button-inserting code) to use message invisibility specs.
2011-06-15Pass message to the `notmuch-show-insert-text/plain-hook' hook.Dmitry Kurochkin
Before the change, the `notmuch-show-insert-text/plain-hook' was given only the `depth' argument. The patch adds another one - the message. Currently, the new message argument is not used by any on the hooks. But it will be used later to get access to message invisibility specs when wash buttons are inserted.
2011-06-15Workaround for Emacs bug #8721.Dmitry Kurochkin
The emacs bug is that isearch cannot search through invisible text when the 'invisible' property is a list. The patch adds `notmuch-isearch-range-invisible' function which is the same as `isearch-range-invisible' but with fixed Emacs bug #8721. Advice added for `isearch-range-invisible' which calls `notmuch-isearch-range-invisible' instead of the original `isearch-range-invisible' when in `notmuch-show-mode'.
2011-06-15test emacs: Add tests for hiding messages in notmuch-show viewDmitry Kurochkin
This test is expected to fail as it exposes a current bug, (which we hope to fix soon).
2011-06-15python: Implement Message.__cmp__ and __hash__Sebastian Spaeth
We can now do: if msg1 == msg2, and we can use set arithmetic on Messages(): s1, s2= msgs1, msgs2 s1.union(s2) s2 -= s1 Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-15python: Remove Messages().__len__Sebastian Spaeth
Messages.__len__() exhausted the iterator and list() inherently calls len(), so we could not invoke list(msgs) without getting errors. Fix this by implementing __nonzero__ but removing __len__ on Messages. Use Query.count_messages() or len(list(msgs)) if you need to know the number. Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2011-06-10test: Fix from-guessing to actually span Received headers over multiple linesCarl Worth
The intent was always to make these Received headers span multiple lines. But the escapes were causing the shell to ignore the newlines, so that the result instead was long Received headers on a single line each. Fixing the intent here doesn't actually change the test-suite results at all.
2011-06-10Fix appending of Received headersStewart Smith
We're not properly concatenating the Received headers if we parse them while requesting a header that isn't Received. this fixes notmuch-reply address detection in a bunch of situations.