aboutsummaryrefslogtreecommitdiff
path: root/test
AgeCommit message (Collapse)Author
2021-01-13emacs: make headings outline-minor-mode compatibleJonas Bernoulli
`outline-minor-mode' treats comments that begin with three or more semicolons as headings. That makes it very convenient to navigate code and to show/hide parts of a file. Elips libraries typically have four top-level sections, e.g.: ;;; notmuch.el --- run notmuch within emacs... ;;; Commentary:... ;;; Code:... ;;; notmuch.el ends here In this package many libraries lack a "Commentary:" section, which is not optimal but okay for most libraries, except major entry points. Depending on how one chooses to look at it, the "... ends here" line is not really a heading that begins a section, because it should never have a "section" body (after all it marks eof). If the file is rather short, then I left "Code:" as the only section that contains code. Otherwise I split the file into multiple sibling sections. The "Code:" section continues to contain `require' and `declare-function' forms and other such "front matter". If and only if I have split the code into multiple sections anyway, then I also added an additional section named just "_" before the `provide' form and shortly before the "...end here" line. This section could also be called "Back matter", but I feel it would be distracting to be that explicit about it. (The IMO unnecessary but unfortunately still obligatory "... ends here" line is already distracting enough as far as I am concerned.) Before this commit some libraries already uses section headings, some of them consistently. When a library already had some headings, then this commit often sticks to that style, even at the cost inconsistent styling across all libraries. A very limited number of variable and function definitions have to be moved around because they would otherwise end up in sections they do not belong into. Sections, including but not limited to their heading, can and should be further improved in the future.
2020-12-25Merge branch 'release'David Bremner
2020-12-25test/T360-symbol-hiding.sh: trim extra output from readelfDavid Bremner
readelf on (at least) ppc64le sometimes generates some extension to the Ndx name inside '[]'. Remove this output to allow our simple column based parsing to work.
2020-12-23test: add regression test for searching with alternate configDavid Bremner
Make sure upcoming changes to config handling do not break command line specification.
2020-12-20test: use keys with group 'test' in T590-libconfigDavid Bremner
In a future commit we want to interoperate better with glib KeyFiles, which need groups for all keys.
2020-12-13test/T360-symbol-hiding: use readelf in place of nmDavid Bremner
It turns out that using nm -P isn't as portable as hoped. In particular with some ELF ABIs (e.g. ppc64 ELFv1), the desired symbols end up in the data section instead of text. The test is currently only functional on ELF based architectures, so I think it's legit to depend on readelf instead of nm. The switch to readelf has the advantage that we can explicitely ask for all of the symbols with global visibility, rather than grepping for notmuch. That seems a more robust approach since it will catch any strangely named global symbols.
2020-09-04test: fix syntax errors in erroring calls to notmuch insertDavid Bremner
notmuch insert does not currently support passing a filename for the input, so all of these tests have an extra error in addition to the one being tested for. Currently this does not make a difference because the error being tested for is caught before the error of an extra command line argument. In the future it might make a difference, and in any case it is confusing.
2020-08-16test: fix uninitialized variable use in T562-lib-databaseDavid Bremner
Fix a copy paste error of using the boolean ret as a notmuch_status_t, and uninitialized.
2020-08-16test: update README to reflect dropping upgrade testsDavid Bremner
These test databases have been unneeded since ee897cab8.
2020-08-15Emacs: Indent first header line only when indentation is turned onTeemu Likonen
Previously in message-show mode message's first header line (From header) was always indented, even if user had turned thread indentation off with "<" (notmuch-show-toggle-thread-indentation) command. This change modifies notmuch-show-insert-headerline function so that it doesn't indent the first header line if notmuch-show-indent-content variable is nil. This change also modifies tests so that they expect this new output format: test/emacs-show.expected-output/notmuch-show-indent-thread-content-off
2020-08-09emacs: Do not abuse advice to monkey patch while testingJonas Bernoulli
Use `cl-letf*' instead.
2020-08-09emacs: Drop old advices that were only need for Emacs 23Jonas Bernoulli
2020-08-09test: Fix indentationJonas Bernoulli
Fix it to consistently match the style we have configured in ".dir-locals.el".
2020-08-09Fix typosJonas Bernoulli
2020-08-09emacs: Various cosmetic changesJonas Bernoulli
2020-08-09emacs: Use makefile-gmake-mode in Makefile*sJonas Bernoulli
Use `makefile-gmake-mode' instead of `makefile-mode' because the former also highlights ifdef et al. while the latter does not. "./Makefile.global" and one "Makefile.local" failed to specify any major mode at all but doing so is necessary because Emacs does not automatically figure out that these are Makefiles (of any flavor).
2020-08-09emacs: Use 'when' instead of 'if' when there is no ELSE partJonas Bernoulli
2020-08-09emacs: Use 'unless' instead of 'when' and 'not'Jonas Bernoulli
Also use 'unless' in a few cases where previously 'if' was used with 'not' but without an ELSE part.
2020-08-09emacs: Fix indentationJonas Bernoulli
2020-08-08T355: specify hash algorithm explicitlyĐoàn Trần Công Danh
On some systems (notably, the one shipped with LibreSSL), default fingerprint digest algorithm is SHA256. On other systems, users can change default digest algorithm by changing default_md in /etc/ssl/default_md. Let's ask openssl to provide us specific algorithm to make the test more deterministic. Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
2020-08-03test: regression tests for n_indexopts_{get,set}_decrypt_policyDavid Bremner
The main criteria is that they don't crash. Working with a closed database is a bonus.
2020-08-03test: regression test for traversing config list with closed dbDavid Bremner
Also mention error return in API docs
2020-08-03test: regression test for n_d_get_config_list on closed db.David Bremner
Exception is caught.
2020-08-03test: regression test for n_directory_{get,set}_mtimeDavid Bremner
The mtime is cached, so closing the db is not a problem. Writing the mtime throws an exception, which is caught.
2020-08-03lib: fix return value for n_directory_deleteDavid Bremner
Falling out of the catch meant the error return was lost
2020-08-03test: known broken test for n_directory_delete with closed db.David Bremner
There is a return value bug in notmuch_directory_delete that is hiding the exception.
2020-08-03lib: catch exceptions in n_directory_get_child_filesDavid Bremner
Also clarify API in error case.
2020-08-03test: add known broken test for n_directory_get_child_filesDavid Bremner
This is a clone of the one for get_child_directories
2020-08-03lib: catch exceptions in n_directory_get_child_directoriesDavid Bremner
Also clarify API in error case.
2020-08-03test: add known broken test for n_directory_get_child_directoriesDavid Bremner
Start a new test file (for the notmuch_directory_* API group) to hold this test.
2020-08-03test: regression test for n_m_get_filenamesDavid Bremner
Closing the database after the iterator is created is not a problem.
2020-08-03test: split header for lib-message tests.David Bremner
This allows finer control over when to close the database.
2020-08-03test: add regression test for n_messages_collect_tagsDavid Bremner
Also test n_messages_destroy.
2020-08-03lib: return NULL from n_d_get_default_indexopts on errorDavid Bremner
This is a rare and probably serious programming error, so better not to silently return a default value.
2020-08-01test: drop use of db_endingDavid Bremner
This will allow the dropping of the test for the default ending from configure.
2020-07-31test: drop NOTMUCH_DEFAULT_XAPIAN_BACKEND from T360-symbol-testDavid Bremner
Inspired by the suggestion of id:20200727154108.16269-3-congdanhqx@gmail.com to drop the configuration test for the default backend. This version is hopefully robust against backend changes.
2020-07-31test: destroy thread from closed databaseDavid Bremner
Check for (non)-crash.
2020-07-31test: regression test for n_thread_get_tagsDavid Bremner
Code is taken from the API docs, with the twist that the underlying database is closed. Not crashing is the main point.
2020-07-31test: add regression tests for oldest and newest datesDavid Bremner
These are strictly to watch for crashes, so don't be too fussy about the actual timestamps.
2020-07-31test: add regression tests for n_t_get_{authors, subject}David Bremner
This is returning explicitely cached data, so no database access is needed.
2020-07-31test: add regression test for n_t_get_messagesDavid Bremner
This is similar to the case of toplevel messages. Currently everything is cached, so no database access is necessary. This might change in the future, but it should not crash in either case.
2020-07-31test: add regression tests for n_thread_get_toplevel_messagesDavid Bremner
Include a test for the previously omitted non-trivial code path for notmuch_thread_get_replies.
2020-07-31test: add regression test for n_thread_get_total_{messages,files}David Bremner
This is returning cached info, so does not need to access the (closed) database.
2020-07-31test: regression test for n_t_get_thread_idDavid Bremner
This is just cached data, so as long as we don't prematurely free anything, it should be fine.
2020-07-29test: regression test for notmuch_query_destroyDavid Bremner
As with other void API entries, not crashing counts as success.
2020-07-29test: regression tests for n_q_count_{messages, threads}David Bremner
At least these exceptions are caught.
2020-07-29test: regression test for n_q_search_messagesDavid Bremner
Exception handling matches notmuch_query_search_threads, at least for this case.
2020-07-29test: regression test for n_q_search_threadsDavid Bremner
At least this exception is caught.
2020-07-29test: add regression test for n_q_add_tag_excludeDavid Bremner
This relies on the change to not tear down the auxilary Xapian objects, in particular the query parser, when the database is closed.
2020-07-29test: regression test for n_q_{set, get}_sortDavid Bremner
We just want to make sure accessing the query owned by a closed db does not cause a crash.
generated by cgit v1.2.3 (git 2.51.0) at 2026-06-24 23:16:19 +0000