notmuch - thread-based email index, search, and tagging

Age	Commit message (Collapse)	Author
2020-07-31	test: destroy thread from closed database	David Bremner
	Check for (non)-crash.
2020-07-31	test: regression test for n_thread_get_tags	David Bremner
	Code is taken from the API docs, with the twist that the underlying database is closed. Not crashing is the main point.
2020-07-31	test: add regression tests for oldest and newest dates	David Bremner
	These are strictly to watch for crashes, so don't be too fussy about the actual timestamps.
2020-07-31	test: add regression tests for n_t_get_{authors, subject}	David Bremner
	This is returning explicitely cached data, so no database access is needed.
2020-07-31	test: add regression test for n_t_get_messages	David Bremner
	This is similar to the case of toplevel messages. Currently everything is cached, so no database access is necessary. This might change in the future, but it should not crash in either case.
2020-07-31	test: add regression tests for n_thread_get_toplevel_messages	David Bremner
	Include a test for the previously omitted non-trivial code path for notmuch_thread_get_replies.
2020-07-31	test: add regression test for n_thread_get_total_{messages,files}	David Bremner
	This is returning cached info, so does not need to access the (closed) database.
2020-07-31	test: regression test for n_t_get_thread_id	David Bremner
	This is just cached data, so as long as we don't prematurely free anything, it should be fine.
2020-07-29	test: regression test for notmuch_query_destroy	David Bremner
	As with other void API entries, not crashing counts as success.
2020-07-29	test: regression tests for n_q_count_{messages, threads}	David Bremner
	At least these exceptions are caught.
2020-07-29	test: regression test for n_q_search_messages	David Bremner
	Exception handling matches notmuch_query_search_threads, at least for this case.
2020-07-29	test: regression test for n_q_search_threads	David Bremner
	At least this exception is caught.
2020-07-29	test: add regression test for n_q_add_tag_exclude	David Bremner
	This relies on the change to not tear down the auxilary Xapian objects, in particular the query parser, when the database is closed.
2020-07-29	test: regression test for n_q_{set, get}_sort	David Bremner
	We just want to make sure accessing the query owned by a closed db does not cause a crash.
2020-07-29	test: regression test for set_omit_excluded	David Bremner

2020-07-29	test: regression test for notmuch_query_get_database	David Bremner
	Current functionality is too trivial to really justify a test, but it's simpler just to test the complete API.
2020-07-29	test: add regression test for n_q_{create,_get_query_string}	David Bremner
	Start a new file of tests, to keep to the (emerging) scheme of one notmuch_foo group per file
2020-07-29	test: move notmuch_message_* tests to their own file	David Bremner
	This is for consistency with the recently added tests for notmuch_database_*.
2020-07-28	test: Explicitly state that we want to sign with sender	Jonas Bernoulli
	Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to signing as the sender using 'mml-secure-openpgp-sign-with-sender'.
2020-07-28	test: Remove misguided emacs testing utilities	Jonas Bernoulli
	The goal of this abstraction was to save space. But that failed as the result actually was that four trivial lines got replace with 15 fairly complicated lines. The opposite of what it was supposed to do. Also it made it harder to come up with the fix in the previous commit; simply grepping for the relevant symbols did not work because they get constructed at run-time instead of appearing in the source file.
2020-07-28	test: Deal with Emacs 27 switching to lexical scope by default	Jonas Bernoulli
	Starting with Emacs 27 undeclared variables in evaluated interactive code uses lexical scope. This includes code passed with '--eval' as we do in the Emacs tests, which also happen to assume dynamic scope. - This can affect variables defined by libraries that we use. We let-bind such variables to change the behavior of functions which we then call with these bindings in effect. If these libraries are not loaded beforehand, then the bindings are lexical and fail to have the effect we intended. At this time only 'smtpmail' has to be loaded explicitly (for the variables let-bound in emacs_deliver_message and emacs_fcc_message). 'message' doesn't have to be loaded explicitly, because loading 'notmuch' (in 'run_emacs') already takes care of that, indirectly. - Our own testing-only variables also have to be declared explicitly. We should have done that anyway, but because of how and where these variables are used it was very easy to overlook that (i.e. it isn't something the byte-compiler ever looks at). Not so in Emacs 27 anymore; here this oversight caused four tests to fail. The numeric values of these variables get incremented by functions that we add to hooks that are run by many tests, not just the tests where we actually inspect the value and therefore take care to let- bind the values to 0 before we begin. The global values therefore have to be numeric values as well. I have chosen -100 instead of 0 as the default in case someone writes a test that inspects the value but forgets to let-bind the value. I hope that the unusual negative value that one is going to see in such a case will help debugging the issue.
2020-07-22	test: add known broken test for n_d_get_default_indexopts	David Bremner
	Xapian exceptions are swallowed and turned into default return value.
2020-07-22	lib: fix error return bug with n_d_set_config.	David Bremner
	The catch block either needs to return, or the function needs to return "status". Choose the latter for consistency with n_d_get_config.
2020-07-22	test: add known broken test for n_d_set_config	David Bremner
	Error status is currently lost.
2020-07-22	test: add regression test for n_d_get_config	David Bremner
	Xapian exceptions seem to handled OK, at least for this case.
2020-07-22	lib: add regresion test for n_d_get_all_tags	David Bremner
	Existing error handling seems adequate, if not ideal.
2020-07-22	lib: add regression test for n_d_find_message_by_filename	David Bremner
	At least this Xapian exception is caught. Make sure it stays that way.
2020-07-22	lib: rename _n_d_create to _n_d_find_or_create	David Bremner
	The error message and name were confusing when called in some "read only" context.
2020-07-22	test: add known broken test for notmuch_database_remove_message	David Bremner
	The current error message is a bit confusing; fix in next commit.
2020-07-22	lib: convert relative filenames to absolute in n_d_index_file	David Bremner
	The API docs promise to handle relative filenames, but the code did not do it. Also check for files outside the mail root, as implied by the API description. This fixes the bug reported at id:87sgdqo0rz.fsf@tethera.net
2020-07-22	test: add known broken test for indexing relative path	David Bremner
	The current code seems to look for the path relative to the current working directory, rather than the mail store root.
2020-07-22	test: regression test for n_d_index_file closed db	David Bremner
	Current exception handling seems OK, at least for this case.
2020-07-22	test: add regression test for n_d_get_directory	David Bremner
	At least this exception is already handled correctly.
2020-07-22	test: regression test for n_d_get_revision	David Bremner
	This function only accesses data cached by notmuch, so being closed is not a problem.
2020-07-22	test: add regression test for n_d_{begin,end}_atomic	David Bremner
	Xapian currently succeeds to begin/end a transaction on a closed database, or at least does not throw an exception. Make the test robust against this changing.
2020-07-22	test: regression test for n_d_upgrade	David Bremner
	The logic is that if it's acceptable to return SUCCESS for read only database, it's acceptable for a closed one.
2020-07-22	lib/n_d_needs_upgrade: handle error return from n_d_get_version	David Bremner
	Also clarify documentation of error return from n_d_needs_upgrade.
2020-07-22	test: add known broken test for n_d_needs_upgrade	David Bremner
	It's a bit arbitrary which value to return for errors, but the same argument as for read only databases applies for errors.
2020-07-22	test: add regression tests for notmuch database destroy	David Bremner
	Either an open or closed database should be ok to destroy
2020-07-22	test: regression test for closing a closed database	David Bremner
	This does not currently throw an error, and it should stay that way.
2020-07-22	lib/n_d_get_version: catch exceptions and clarify the API	David Bremner
	notmuch_database_get_version previously returned 0 on some errors, but did not document this. Luckily 0 is not a valid database version.
2020-07-22	test: add known broken test for n_d_get_version on closed db	David Bremner
	This should not crash, but it does currently.
2020-07-22	test: regression tests for n_d_status_string and n_d_get_path	David Bremner
	These do not crash on a closed database, and we want to keep it that way. Start a new file of tests as T560-lib-error was starting to get unwieldy.
2020-07-22	lib: fix exception messages for n_m_message_*	David Bremner
	The original generic handler had an extra '%s' in the format string. Update tests that failed to catch this because the template to print status strings checked 'stat', which was not set.
2020-07-22	test: sanitize line numbers in exception reports	David Bremner
	Prevent test suite churn when reported line numbers change.
2020-07-20	lib: fix return value for n_m_reindex	David Bremner
	Also update the documentation for the behaviour of n_m_get_thread_id that this fix relies on.
2020-07-20	test: add known broken test for n_m_reindex on closed db	David Bremner
	This is another case where the code should not call INTERNAL_ERROR.
2020-07-20	test: regression for retrieving closed db from message	David Bremner
	This is actually one of the few potentially useful things you can do with a message belonging to a closed database, since in principle you could re-open the database.
2020-07-20	test: regression test for destroying message with closed db	David Bremner
	This should be fine because the message belongs to the database (talloc context wise).
2020-07-20	test: regression tests of n_m_freeze and n_m_thaw on closed db	David Bremner
	Neither of these accesses the database, so should be safe. Add the tests to catch any changes in exception throwing.