From: Timur Tabi Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port Date: Tue, 3 Aug 2010 08:01:51 -0500 Lines: 25 Message-ID: References: <20100308191005.GE4324@amak.tundra.com> <4381.1280815590@neuling.org> <0CE8B6BE3C4AD74AB97D9D29BD24E5520114309D@CORPEXCH1.na.ads.idt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Michael Neuling , Alexandre Bounine , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, thomas.moll@sysgo.com, Kumar Gala To: "Bounine, Alexandre" X-From: linux-kernel-owner@vger.kernel.org Tue Aug 03 15:02:39 2010 Return-path: Envelope-to: glk-linux-kernel-3@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OgH8b-0003r0-5v for glk-linux-kernel-3@lo.gmane.org; Tue, 03 Aug 2010 15:02:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756383Ab0HCNCY (ORCPT ); Tue, 3 Aug 2010 09:02:24 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:47377 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253Ab0HCNCX (ORCPT ); Tue, 3 Aug 2010 09:02:23 -0400 Received: by qyk7 with SMTP id 7so647758qyk.19 for ; Tue, 03 Aug 2010 06:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type; bh=vTJghTE4Rwcgvgu1RS/86u/ljjztFlVQ5ODYWXBRkUM=; b=p7S+ZVc0INWI6uXFwsLVTTEnV8wFAB0u0cDLt5qp0gyuMbF9yqXhukSTbYS8Vf8gCk UFDmrOGjzC1whtvZnRS+Q80vVTR3+1URt/RTCUqirvalLvgluNrzP6sQ3xccFy4LkdLi nGsgcNEqVwPPZgg3uSqew6B5UIoH7S00YzAYU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=qNVeIlTzozhY9MXH5PHYIsAL8T7zOBZ+0hWrBlbEy0PiBHW1AAv9nNd6FspugBZVUW q7iPmhg0n6Oa3KFBNjs42dInyCPUqiQs10rGTQCJsSVITmZ/NA9sf8FFbI+Dg7xQiJKj TN/8W0tBK9mUiqVvoO1avTKG1hqyMwTdMqlaM= Received: by 10.224.73.18 with SMTP id o18mr2669587qaj.354.1280840541149; Tue, 03 Aug 2010 06:02:21 -0700 (PDT) Received: by 10.220.112.69 with HTTP; Tue, 3 Aug 2010 06:01:51 -0700 (PDT) In-Reply-To: <0CE8B6BE3C4AD74AB97D9D29BD24E5520114309D@CORPEXCH1.na.ads.idt.com> X-Google-Sender-Auth: lBedzmn1VMYh0pQjuCJuDw-lNh8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archived-At: On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre wrote: > This happened after change to book-e definitions. > There are patches that address this issue. And those patches should have been applied before 2.6.35 was released. Someone dropped the ball. 2.6.35 is broken for a number of PowerPC boards: $ make mpc85xx_defconfig ... $ make ... CC arch/powerpc/sysdev/fsl_rio.o arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared (first use in this function) arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 -- Timur Tabi Linux kernel developer at Freescale