]> git.notmuchmail.org Git - notmuch/commit
lib/create: fix memory leak, ensure *database=NULL on error
authorDavid Bremner <david@tethera.net>
Sat, 23 Oct 2021 13:22:36 +0000 (10:22 -0300)
committerDavid Bremner <david@tethera.net>
Sat, 30 Oct 2021 16:47:47 +0000 (13:47 -0300)
commit2ba50b52302dce08068843e0029f9ee935a0d7f3
treed52b8595858c0575e4aabe89f113de37b7e30f24
parentf3fcdd2ddac2384c0c1daeffa495ad3ec01bc1af
lib/create: fix memory leak, ensure *database=NULL on error

This code previously relied on _finish_open to free the notmuch struct
on errors (except for the case of database == NULL, which was a
potential double free). When we removed those frees from _finish_open,
we introduced a (small) memory leak.

In this commit, fix the memory leak, and harmonize the on-error
behaviour with n_d_open_with_config.
lib/open.cc
test/T590-libconfig.sh