]> git.notmuchmail.org Git - notmuch/commitdiff
notmuch-show-imenu-prev-index-position-function: Don't recenter
authorDamien Cassou <damien@cassou.me>
Sun, 16 Feb 2025 21:22:23 +0000 (22:22 +0100)
committerDavid Bremner <david@tethera.net>
Tue, 18 Feb 2025 12:54:36 +0000 (08:54 -0400)
The previous version of
notmuch-show-imenu-prev-index-position-function was calling
notmuch-show-previous-message which was recentering the window. This
is a problem when which-func-mode is active because which-func-mode is
called each time the user moves point around.

Because this function is only meant to be executed by imenu, there is
no reason to recenter the window. For the same reason, the new
implementation doesn't have to follow strictly how
notmuch-show-previous-message is implemented because imenu only places
point at very specific locations before calling
notmuch-show-imenu-prev-index-position-function.

emacs/notmuch-show.el

index 14e3c698693e1c1954a5f3682532083e05ab5150..921c0ef1e4e339aa5d0366ef04b785f407ea60f8 100644 (file)
@@ -2686,7 +2686,9 @@ This function is used as a value for
 `imenu-prev-index-position-function'."
   (if (bobp)
       nil
-    (notmuch-show-previous-message)
+    (if (eobp)
+       (notmuch-show-move-to-message-top)
+      (notmuch-show-goto-message-previous))
     t))
 
 (defun notmuch-show-imenu-extract-index-name-function ()