From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Wed, 16 Jun 2010 14:14:18 +0000 (+0200)
Subject: Do not call ldconfig when building Debian package
X-Git-Tag: 0.4~30
X-Git-Url: https://git.notmuchmail.org/git?a=commitdiff_plain;ds=inline;h=f7a688ec5314e668a6976805ae88d4e62f7cbd89;p=notmuch

Do not call ldconfig when building Debian package

Hi,

If I want to build Debian package, it fails with the following message:

    ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied
    make[1]: *** [install-lib] Error 1

The reason is that I build the package as a non-root user and make
install invokes ldconfig unconditionally. The following patch contains a
workaround, but I think that a more correct solution would be to check
the condition LIBDIR_IN_LDCONFIG directly when make install is invoked
rather than in configure as it is done now.

Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
---

diff --git a/lib/Makefile.local b/lib/Makefile.local
index a60ef989..2d36db1c 100644
--- a/lib/Makefile.local
+++ b/lib/Makefile.local
@@ -36,9 +36,11 @@ SONAME = $(LINKER_NAME).$(LIBNOTMUCH_VERSION_MAJOR)
 LIBNAME = $(SONAME).$(LIBNOTMUCH_VERSION_MINOR).$(LIBNOTMUCH_VERSION_RELEASE)
 LIBRARY_LINK_FLAG = -shared -Wl,-soname=$(SONAME)
 ifeq ($(LIBDIR_IN_LDCONFIG),1)
+ifeq ($(DESTDIR),)
 LIBRARY_INSTALL_POST_COMMAND=ldconfig
 endif
 endif
+endif
 
 dir := lib
 extra_cflags += -I$(dir) -fPIC