From: William Morgan Date: Wed, 13 May 2009 20:08:51 +0000 (-0700) Subject: bugfix: further fixing of split usage X-Git-Url: https://git.notmuchmail.org/git?a=commitdiff_plain;h=569922ef628485cd6ac453c11c994053b7d213af;p=sup bugfix: further fixing of split usage Clean up a couple remaining non-optimal uses of String#split. --- diff --git a/lib/sup/index.rb b/lib/sup/index.rb index 2bdf22b..853bf76 100644 --- a/lib/sup/index.rb +++ b/lib/sup/index.rb @@ -333,7 +333,7 @@ EOS q = Ferret::Search::BooleanQuery.new true sq = Ferret::Search::PhraseQuery.new(:subject) - wrap_subj(Message.normalize_subj(m.subj)).split(/\s+/).each do |t| + wrap_subj(Message.normalize_subj(m.subj)).split.each do |t| sq.add_term t end q.add_query sq, :must @@ -378,7 +378,7 @@ EOS unless messages.member?(mid) #Redwood::log "got #{mid} as a child of #{id}" messages[mid] ||= lambda { build_message docid } - refs = @index[docid][:refs].split(" ") + refs = @index[docid][:refs].split pending += refs.select { |id| !searched[id] } end end @@ -409,9 +409,9 @@ EOS "date" => Time.at(doc[:date].to_i), "subject" => unwrap_subj(doc[:subject]), "from" => doc[:from], - "to" => doc[:to].split(/\s+/).join(", "), # reformat + "to" => doc[:to].split.join(", "), # reformat "message-id" => doc[:message_id], - "references" => doc[:refs].split(/\s+/).map { |x| "<#{x}>" }.join(" "), + "references" => doc[:refs].split.map { |x| "<#{x}>" }.join(" "), } Message.new :source => source, :source_info => doc[:source_info].to_i,